fix(int128): Use all 16 decimal digits to represent int128 min/max in double number correctly #8633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… double correctly
AlexPeshkoff
requested changes
Jun 27, 2025
| static const double I128_MAX_dbl = 1.7014118346046921e+38; | ||
| static const CDecimal128 I128_MIN_dcft("-1.701411834604692317316873037158841E+38", decSt); | ||
| static const CDecimal128 I128_MAX_dcft("1.701411834604692317316873037158841E+38", decSt); | ||
| static const CDecimal128 I128_MAX_dcft( "1.701411834604692317316873037158841E+38", decSt); |
Contributor
Author
There was a problem hiding this comment.
To look in line with I128_MIN_dcft, like it's done with I128_MIN_dbl and I128_MAX_dbl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value
I128_MIN_dblwas not represented precisely, as it didn't utilize all 16 decimal digits (52 bits of mantissa) available in a double-precision number. As a result, the value was rounded down to the closest representable number in the double format.This inaccuracy led to an error in the following query: