Fix #8639 - Concurrency problem in remote profiler communication mechanism #8645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asfernandes
force-pushed
the
work/gh-8639/profiler-cancel-boost-ipc
branch
from
a281650 to
3241a45
Compare
asfernandes
changed the title
asfernandes
force-pushed
the
work/gh-8639/profiler-cancel-boost-ipc
branch
from
52af692 to
d69eaf5
Compare
Member
|
Out of curiosity, how do you recover from the shared spinlock being "locked" but the process holding that spinlock crashed? I'm mostly worried about CS. So far we were using shared mutexes because they get automatically "unlocked" in such scenario. |
Member
I also want to know an answer. Despite the merged PR! |
Member
Author
I will look at this with more detail. |
Contributor
|
What will be wrong if the initialization of the shared memory structures (mutex) is done under file lock? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.