Skip to content

Commit e206bf5

Browse files
committed
Add Firebird struct names in comments for reference
1 parent f987581 commit e206bf5

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

src/main/org/firebirdsql/gds/ng/wire/version10/V10Database.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -335,10 +335,10 @@ public final FbTransaction reconnectTransaction(long transactionId) throws SQLEx
335335
private void sendReconnect(long transactionId) throws SQLException {
336336
try {
337337
final XdrOutputStream xdrOut = getXdrOut();
338-
xdrOut.writeInt(op_reconnect);
339-
xdrOut.writeInt(0);
338+
xdrOut.writeInt(op_reconnect); // p_operation
339+
xdrOut.writeInt(0); // p_sttr_database
340340
final byte[] transactionIdBuffer = getTransactionIdBuffer(transactionId);
341-
xdrOut.writeBuffer(transactionIdBuffer);
341+
xdrOut.writeBuffer(transactionIdBuffer); // p_sttr_tpb
342342
xdrOut.flush();
343343
} catch (IOException e) {
344344
throw FbExceptionBuilder.ioWriteError(e);

src/main/org/firebirdsql/gds/ng/wire/version11/V11WireOperations.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -119,10 +119,10 @@ public final void processDeferredActions() {
119119
* Can be used for additional actions after processing deferred actions (e.g. trim a large deferred actions list to
120120
* its default capacity).
121121
* <p>
122-
* This implementation trims if {@code processedDeferredActions > 10}. When overridden, it is recommend to call this
123-
* method through {@code super} to still trim (e.g. in a more limited set of circumstances) and perform any other
124-
* actions this method may perform. If the overridden method wants to forgo trimming, it should pass {@code -1} for
125-
* {@code processedDeferredActions}.
122+
* This implementation trims if {@code processedDeferredActions > 10}. When overridden, it is recommended to call
123+
* this method through {@code super} to still trim (e.g. in a more limited set of circumstances) and perform any
124+
* other actions this method may perform. If the overridden method wants to forgo trimming, it should pass
125+
* {@code -1} for {@code processedDeferredActions}.
126126
* </p>
127127
*
128128
* @param processedDeferredActions

src/main/org/firebirdsql/gds/ng/wire/version12/V12Database.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@ private void sendCancel(int kind) throws SQLException {
5959
// We circumvent the normal xdrOut to minimize the chance of interleaved writes
6060
ByteArrayOutputStream out = new ByteArrayOutputStream(8);
6161
try (XdrOutputStream xdr = new XdrOutputStream(out, 8)) {
62-
xdr.writeInt(WireProtocolConstants.op_cancel);
63-
xdr.writeInt(kind);
62+
xdr.writeInt(WireProtocolConstants.op_cancel); // p_operation
63+
xdr.writeInt(kind); // p_co_kind
6464
}
6565
wireOperations.writeDirect(out.toByteArray());
6666
} catch (IOException e) {

0 commit comments

Comments
 (0)