switch to poetry and modernize, touch up tests

Signed-off-by: David Ford <[email protected]>

Author: FirefighterBlu3

poetry.lock

@@ -1,71 +1,56 @@
-[build-system]
-requires = [
-    'setuptools>=44',
-    'wheel>=0.30.0',
-    'six',
+[project]
+name = "python-pam"
+version = "2.1.0-beta1"
+description = ""
+authors = [{name = "David Ford", email = "[email protected]"}]
+readme = "README.md"
+requires-python = ">=3.10"
+dependencies = [
+    "six",
 ]
-build-backend = 'setuptools.build_meta'
-
-# ignore the tox documentation, it IS NOT supported yet
-# https://github.com/tox-dev/tox/issues/2148
-#[tox]
-#isolated_build = true
 
-[tool.tox]
-legacy_tox_ini = """
-[tox]
-envlist = py310
-isolated_build = true
-#skipsdist = true
+[tool.poetry]
+packages = [{include = "pam", from = "python-pam"}]
 
-[gh-actions]
-python =
-    3.7: py37
-    3.8: py38
-    3.9: py39
-    3.10: py310
+[tool.poetry.group.dev.dependencies]
+pytest = "^6.2.4"
+pytest-cov = "^4.0.0"
+pylint = "^3.0.0"
+tox = "^4.0.0"
+bandit = "*"
 
-[testenv]
-basepython = python3.10
-passenv = *
-deps =
-    bandit
-    flake8
-    mypy
-    types-six
-    coverage
-    pytest-cov
-    pytest
-    -rrequirements.txt
+[tool.coverage.run]
+source = ["pam"]
+omit = ["*/tests/*", "*/test_*.py"]
 
-commands =
-    flake8 src/pam/
-    mypy
-    bandit -r src -c "pyproject.toml"
-    pytest --cov -r w --capture=sys -vvv --cov-report=html
-"""
+[tool.coverage.report]
+precision = 2
+show_missing = true
+skip_covered = false
+fail_under = 85.0
 
 [tool.bandit]
 exclude_dirs = ["./venv", "./test", ]
 recursive = true
 
-[tool.mypy]
-files = ["src/pam/__init__.py", "src/pam/__internals.py"]
-ignore_missing_imports = true
-
-[tool.pytest]
-python_files = "test_*.py"
-norecursedirs = ".tox"
-
-[tool.coverage.run]
-branch = true
-# awkward how I can include "pam" but I have to be incredibly specific when omitting
-source = ["pam"]
-omit = ["*/pam/pam.py", "*/pam/version.py",]
-
-[tool.coverage.html]
-directory = "htmlcov"
+[tool.pylint.main]
+jobs = 0
+
+[tool.pylint.format]
+max-line-length = 120
+
+[tool.pylint."messages control"]
+disable = [
+    "too-many-arguments",
+    "too-many-positional-arguments",
+    "too-many-branches",
+    "too-many-statements",
+    "too-many-locals",
+    "too-many-instance-attributes",
+    "too-few-public-methods",
+    "wrong-import-position",  # Imports are intentionally after version check
+]
 
-[tool.coverage.report]
-skip_empty = true
-fail_under = 100
+[build-system]
+requires = ["poetry-core"]
+build-backend = "poetry.core.masonry.api"

pyproject.toml

@@ -1,9 +1,9 @@
-import sys as __sys
+"""PAM (Pluggable Authentication Modules) interface for Python.
 
-if __sys.version_info < (3, ):  # pragma: no cover
-    print('WARNING, Python 2 is EOL and therefore py2 support in this '
-          "package is deprecated. It won't be actively checked for"
-          'correctness')
+This module provides a Python interface to Linux-PAM, allowing authentication
+against system PAM services.
+"""
+import sys as __sys
 
 # list all the constants and export them
 from .__internals import PAM_ACCT_EXPIRED
@@ -58,6 +58,11 @@
 from .__internals import PAM_XDISPLAY
 from .__internals import PamAuthenticator
 
+if __sys.version_info < (3, ):  # pragma: no cover
+    print('WARNING, Python 2 is EOL and therefore py2 support in this '
+          "package is deprecated. It won't be actively checked for"
+          'correctness')
+
 __all__ = [
     'authenticate',
     'pam',
@@ -124,7 +129,25 @@ def authenticate(username,
                  encoding='utf-8',
                  resetcreds=True,
                  print_failure_messages=False):
-    global __PA
+    """Authenticate a user against PAM.
+
+    This is a convenience function that creates a PamAuthenticator instance
+    (reusing a global instance if available) and calls its authenticate method.
+
+    Args:
+        username: Username to authenticate
+        password: Password in plain text
+        service: PAM service to authenticate against (default: 'login')
+        env: Dictionary of environment variables to set
+        call_end: Whether to call pam_end() after authentication (default: True)
+        encoding: Encoding to use for string conversions (default: 'utf-8')
+        resetcreds: Whether to reset credentials after authentication (default: True)
+        print_failure_messages: Whether to print failure messages (default: False)
+
+    Returns:
+        bool: True if authentication succeeded, False otherwise
+    """
+    global __PA  # noqa: PLW0603
 
     if __PA is None:  # pragma: no branch
         __PA = PamAuthenticator()
@@ -133,5 +156,5 @@ def authenticate(username,
 
 
 # legacy implementations used pam.pam()
-pam = PamAuthenticator
+pam = PamAuthenticator  # noqa: N816, C0103
 authenticate.__doc__ = PamAuthenticator.authenticate.__doc__