4.6.5

- Fixed instance of Multipass Id not found error.
- Fixed rare chance of Observers not removing a disconnected client when using multiple transports and only one is disconnected.
- Fixed internal NetworkInitialize methods are now called before OnStartNetwork even if the object is disabled.
- Improved SyncVar initial value will not overwrite synchronized value in the condition object receives synchronized value while disabled, and is later enabled for the first time.
- Fixed OnStop callbacks not occuring on nested objects when disconnecting the transport socket.
- Added TimeManager.HalfRoundTripTime.
- Added Beta Recursive Despawns for internal change.
- Fixed NetworkTransform.LastObserversRpcTick not resetting.
- Improved adaptive interpolation to be more consistent and efficient.
- Fixed harmless errors when using DebugManager Validate Rpc Lengths.
- Added Tugboat.StopSocketsOnThread to stop local connections using a thread (default/current behavior).
- Improved Tugboat now tries to stop the socket if detected as started when starting a new connection.
- Fixed unicode strings not writing proper length.
- Fixed large replicates not splitting into multiple packets.
- Added UniversalTickSmoother.Set/GetAdditionalGraphicalOffsetValues.
- Fixed SyncType.ResetState NullReferenceException.
- Fixed UniversalTickSmoother interpolation times changing eratically resulting in smoothing pausing.
- Fixed RigidbodyPrediction demo 'boostStart' check (#870).
- Fixed NewNetworkBehaviour template missing file exception.
- Fixed warning when Time/PredictionManager would try to simulate physics with a 0f timescale (#860).
- Fixed NetworkTransform stuttering spectated objects as host when using a send interval larger than 1.
- Fixed prediction corrupting class instance memory.

Author: FirstGearGames

Assets/FishNet/CodeGenerating/Processing/NetworkBehaviourProcessor.cs

@@ -22,10 +22,9 @@ internal class NetworkBehaviourProcessor : CodegenBase
         #endregion
 
         #region Const.
-        internal const string EARLY_INITIALIZED_NAME = "NetworkInitializeEarly_";
-        internal const string LATE_INITIALIZED_NAME = "NetworkInitializeLate_";
         internal const string NETWORKINITIALIZE_EARLY_INTERNAL_NAME = "NetworkInitialize___Early";
-        internal const string NETWORKINITIALIZE_LATE_INTERNAL_NAME = "NetworkInitialize__Late";
+        internal const string NETWORKINITIALIZE_LATE_INTERNAL_NAME = "NetworkInitialize___Late";
+        private readonly string[] _networkInitializeMethodNames = new string[] { NETWORKINITIALIZE_EARLY_INTERNAL_NAME, NETWORKINITIALIZE_LATE_INTERNAL_NAME };
         #endregion
 
         internal bool ProcessLocal(TypeDefinition typeDef)
@@ -65,10 +64,10 @@ internal bool ProcessLocal(TypeDefinition typeDef)
              * multiple times. EG: with this solution if parent had 1 sync type
              * and childA had 2 the parent would be index 0, and childA would have 1 and 2.
              * But also, if childB inherited childA it would have 3+.
-             * 
+             *
              * Going in reverse also gaurantees the awake method will already be created
-            * or modified in any class a child inherits. This lets us call it appropriately
-            * as well error if the awake does not exist, such as could not be created. */
+             * or modified in any class a child inherits. This lets us call it appropriately
+             * as well error if the awake does not exist, such as could not be created. */
             typeDefs.Reverse();
 
             foreach (TypeDefinition td in typeDefs)
@@ -77,7 +76,7 @@ internal bool ProcessLocal(TypeDefinition typeDef)
                  * can use it. */
                 MethodDefinition networkInitializeIfDisabledMd;
                 CreateNetworkInitializeMethods(td, out networkInitializeIfDisabledMd);
-                CallNetworkInitializesFromNetworkInitializeIfDisabled(networkInitializeIfDisabledMd);
+                CallNetworkInitialize(networkInitializeIfDisabledMd);
 
 
 
@@ -111,7 +110,7 @@ internal bool ProcessLocal(TypeDefinition typeDef)
                 //Copy user logic from awake into a new method.
                 CopyAwakeUserLogic(td);
                 /* Create awake method or if already exist make
-                * it public virtual. */
+                 * it public virtual. */
                 if (!ModifyAwakeMethod(td, out bool awakeCreated))
                 {
                     //This is a hard fail and will break the solution so throw here.
@@ -146,7 +145,6 @@ internal bool ProcessLocal(TypeDefinition typeDef)
         /// </summary>
         internal string GetAwakeUserLogicMethodDefinition(TypeDefinition td) => $"Awake_UserLogic_{td.FullName}_{base.Module.Name}";
 
-
         /// <summary>
         /// Returns if a class has been processed.
         /// </summary>
@@ -207,7 +205,7 @@ internal bool NonNetworkBehaviourHasInvalidAttributes(Collection<TypeDefinition>
         private void CallBaseAwake(TypeDefinition td)
         {
             /* If base is not a class which can be processed then there
-            * is no need to continue. */
+             * is no need to continue. */
             if (!td.CanProcessBaseType(base.Session))
                 return;
 
@@ -221,7 +219,6 @@ private void CallBaseAwake(TypeDefinition td)
             processor.Emit(OpCodes.Call, baseAwakeMr);
         }
 
-
         /// <summary>
         /// Calls the next awake method if the nested awake was created by codegen.
         /// </summary>
@@ -241,7 +238,6 @@ private void CallAwakeUserLogic(TypeDefinition td)
             base.GetClass<GeneralHelper>().CallCopiedMethod(awakeMd, userLogicMd);
         }
 
-
         /// <summary>
         /// Adds a check to NetworkInitialize to see if it has already run.
         /// </summary>
@@ -287,23 +283,22 @@ void AddCheck(string methodName)
         /// </summary>
         private void CallBaseOnNetworkInitializeMethods(TypeDefinition typeDef)
         {
-            //If base class cannot have a networkinitialize no reason to continue.
-            if (!typeDef.CanProcessBaseType(base.Session))
+            //If base is null cannot call base.
+            if (typeDef.BaseType == null)
                 return;
 
-            string[] initializeMethodNames = new string[] { NETWORKINITIALIZE_EARLY_INTERNAL_NAME, NETWORKINITIALIZE_LATE_INTERNAL_NAME };
-            foreach (string mdName in initializeMethodNames)
+            foreach (string mdName in _networkInitializeMethodNames)
             {
-                /* Awake will always exist because it was added previously.
-                * Get awake for copy and base of copy. */
-                MethodDefinition thisMd = typeDef.GetMethod(mdName);
-                ILProcessor processor = thisMd.Body.GetILProcessor();
-
-                /* Awake will always exist because it was added previously.
-                 * Get awake for copy and base of copy. */
                 MethodReference baseMr = typeDef.GetMethodReferenceInBase(base.Session, mdName);
+                //Not found in base.
+                if (baseMr == null)
+                    continue;
+                
                 MethodDefinition baseMd = baseMr.CachedResolve(base.Session);
 
+                MethodDefinition thisMd = typeDef.GetMethod(mdName);
+                ILProcessor processor = thisMd.Body.GetILProcessor();
+
                 bool alreadyHasBaseCall = false;
                 //Check if already calls baseAwake.
                 foreach (Instruction item in thisMd.Body.Instructions)
@@ -328,11 +323,12 @@ private void CallBaseOnNetworkInitializeMethods(TypeDefinition typeDef)
                     //Create instructions for base call.
                     List<Instruction> instructions = new()
                     {
-                                processor.Create(OpCodes.Ldarg_0), //this.
-                                processor.Create(OpCodes.Call, baseMr)
-                            };
+                        processor.Create(OpCodes.Ldarg_0), //this.
+                        processor.Create(OpCodes.Call, baseMr)
+                    };
                     processor.InsertFirst(instructions);
                 }
+                
             }
         }
 
@@ -345,8 +341,7 @@ private void AddReturnToAwake(TypeDefinition td)
             MethodDefinition awakeMd = td.GetMethod(NetworkBehaviourHelper.AWAKE_METHOD_NAME);
             ILProcessor processor = awakeMd.Body.GetILProcessor();
             //If no instructions or the last instruction isnt ret.
-            if (processor.Body.Instructions.Count == 0
-                || processor.Body.Instructions[processor.Body.Instructions.Count - 1].OpCode != OpCodes.Ret)
+            if (processor.Body.Instructions.Count == 0 || processor.Body.Instructions[processor.Body.Instructions.Count - 1].OpCode != OpCodes.Ret)
             {
                 processor.Emit(OpCodes.Ret);
             }
@@ -392,22 +387,21 @@ MethodDefinition CreateMethod(string name, MethodDefinition copied = null)
             }
         }
 
-
         /// <summary>
         /// Creates an 'NetworkInitialize' method which is called by the childmost class to initialize scripts on Awake.
         /// </summary>
-        private void CallNetworkInitializesFromNetworkInitializeIfDisabled(MethodDefinition networkInitializeIfDisabledMd)
+        private void CallNetworkInitialize(MethodDefinition networkIntializeMd)
         {
-            ILProcessor processor = networkInitializeIfDisabledMd.Body.GetILProcessor();
+            ILProcessor processor = networkIntializeMd.Body.GetILProcessor();
 
-            networkInitializeIfDisabledMd.Body.Instructions.Clear();
+            networkIntializeMd.Body.Instructions.Clear();
             CallMethod(NETWORKINITIALIZE_EARLY_INTERNAL_NAME);
             CallMethod(NETWORKINITIALIZE_LATE_INTERNAL_NAME);
             processor.Emit(OpCodes.Ret);
 
             void CallMethod(string name)
             {
-                MethodReference initIfDisabledMr = networkInitializeIfDisabledMd.DeclaringType.GetMethodReference(base.Session, name);
+                MethodReference initIfDisabledMr = networkIntializeMd.DeclaringType.GetMethodReference(base.Session, name);
                 processor.Emit(OpCodes.Ldarg_0);
                 processor.Emit(initIfDisabledMr.GetCallOpCode(base.Session), initIfDisabledMr);
             }
@@ -473,8 +467,7 @@ internal void CreateFirstNetworkInitializeCall(TypeDefinition typeDef, MethodDef
             {
                 created = true;
 
-                thisAwakeMethodDef = new(NetworkBehaviourHelper.AWAKE_METHOD_NAME, MethodDefinitionExtensions.PUBLIC_VIRTUAL_ATTRIBUTES,
-                    typeDef.Module.TypeSystem.Void);
+                thisAwakeMethodDef = new(NetworkBehaviourHelper.AWAKE_METHOD_NAME, MethodDefinitionExtensions.PUBLIC_VIRTUAL_ATTRIBUTES, typeDef.Module.TypeSystem.Void);
                 thisAwakeMethodDef.Body.InitLocals = true;
                 typeDef.Methods.Add(thisAwakeMethodDef);
 
@@ -500,14 +493,11 @@ internal void CreateFirstNetworkInitializeCall(TypeDefinition typeDef, MethodDef
             if (created && firstUserAwakeMethodDef != null)
             {
                 MethodReference baseAwakeMethodRef = typeDef.Module.ImportReference(firstUserAwakeMethodDef);
-                instructions.Add(processor.Create(OpCodes.Ldarg_0));//this.
+                instructions.Add(processor.Create(OpCodes.Ldarg_0)); //this.
                 instructions.Add(processor.Create(OpCodes.Call, baseAwakeMethodRef));
             }
 
             processor.InsertFirst(instructions);
         }
-
-
-
     }
 }

Assets/FishNet/CodeGenerating/Processing/Prediction/PredictionProcessor.cs

@@ -122,10 +122,10 @@ public override bool ImportReferences()
             base.ImportReference(typeof(BasicQueue<>));
             ReplicateULDelegate_TypeRef = base.ImportReference(typeof(ReplicateUserLogicDelegate<>));
             ReconcileULDelegate_TypeRef = base.ImportReference(typeof(ReconcileUserLogicDelegate<>));
- 
+
             TypeDefinition replicateDataTd = base.ImportReference(typeof(ReplicateDataContainer<>)).CachedResolve(base.Session);
             ReplicateData_Ctor_MethodRef = base.ImportReference(replicateDataTd.GetConstructor(parameterCount: 2));
-            
+
             //Get/Set tick.
             locType = typeof(IReplicateData);
             foreach (SR.MethodInfo mi in locType.GetMethods())
@@ -562,7 +562,6 @@ private void CreateFields(TypeDefinition typeDef, MethodDefinition replicateMd,
         {
             GeneralHelper gh = base.GetClass<GeneralHelper>();
             TypeReference replicateDataTr = replicateMd.Parameters[0].ParameterType;
-            TypeReference replicateDataArrTr = replicateDataTr.MakeArrayType();
             TypeReference reconcileDataTr = reconcileMd.Parameters[0].ParameterType;
 
             GenericInstanceType git;
@@ -597,7 +596,8 @@ private void CreateFields(TypeDefinition typeDef, MethodDefinition replicateMd,
             typeDef.Fields.Add(lastReconcileDataFd);
 
             //Used for delta replicates.
-            FieldDefinition lastReadReplicateFd = new($"_lastReadReplicate___{replicateMd.Name}", FieldAttributes.Private, replicateDataTr);
+            git = gh.GetGenericType(typeof(ReplicateDataContainer<>), replicateDataTr);
+            FieldDefinition lastReadReplicateFd = new($"_lastReadReplicate___{replicateMd.Name}", FieldAttributes.Private, git);
             typeDef.Fields.Add(lastReadReplicateFd);
 
             predictionFields = new()
@@ -746,7 +746,7 @@ bool CreateReplicate()
                 //new ReplicateData<T>(data, channel)
                 processor.Emit(OpCodes.Ldarg, replicateDataPd);
                 processor.Emit(OpCodes.Ldarg, channelPd);
-                GenericInstanceType git = GetGenericReplicateData(replicateDataTr);
+                GenericInstanceType git = GetGenericReplicateDataContainer(replicateDataTr);
                 MethodReference ctorMr = ReplicateData_Ctor_MethodRef.MakeHostInstanceGeneric(base.Session, git);
                 processor.Emit(OpCodes.Newobj, ctorMr);
 
@@ -1062,15 +1062,15 @@ private bool CreateReconcileReader(TypeDefinition typeDef, MethodDefinition reco
             MethodReference methodGim = nbh.Reconcile_Reader_MethodRef.GetMethodReference(base.Session, dataTr);
 
             processor.Emit(OpCodes.Ldarg_0);
-            
+
             /* nb.Reconcile_Reader(readerPd, ref lastReadReconcile); */
             processor.Emit(OpCodes.Ldarg, readerPd);
             //Data to assign read value to.
             processor.Emit(OpCodes.Ldarg_0);
             processor.Emit(OpCodes.Ldflda, predictionFields.LastReadReconcile);
 
             processor.Emit(OpCodes.Call, methodGim);
-            
+
             //Add end of method.
             processor.Emit(OpCodes.Ret);
 
@@ -1081,11 +1081,10 @@ private bool CreateReconcileReader(TypeDefinition typeDef, MethodDefinition reco
         /// <summary>
         /// Outputs generic RingBuffer for dataTr.
         /// </summary>
-        public GenericInstanceType GetGenericReplicateData(TypeReference dataTr)
+        public GenericInstanceType GetGenericReplicateDataContainer(TypeReference dataTr)
         {
-            TypeReference containerTr = base.ImportReference(typeof(ReplicateDataContainer<>));
-            return containerTr.MakeGenericInstanceType(dataTr);
-
+            TypeReference typeTr = base.ImportReference(typeof(ReplicateDataContainer<>));
+            return typeTr.MakeGenericInstanceType(new TypeReference[] { dataTr });
         }
         #endregion
     }

Assets/FishNet/Demos/Benchmarks/NetworkTransform/Scenes/NetworkTransform Benchmark.unity

@@ -1194,6 +1194,7 @@ GameObject:
   - component: {fileID: 7443408886575219566}
   - component: {fileID: 7443408886575219567}
   - component: {fileID: 7443408886575219568}
+  - component: {fileID: 7443408886575219569}
   m_Layer: 0
   m_Name: NetworkManager
   m_TagString: Untagged
@@ -1291,3 +1292,22 @@ MonoBehaviour:
     type: 3}
   _addToDefaultScene: 1
   Spawns: []
+--- !u!114 &7443408886575219569
+MonoBehaviour:
+  m_ObjectHideFlags: 0
+  m_CorrespondingSourceObject: {fileID: 0}
+  m_PrefabInstance: {fileID: 0}
+  m_PrefabAsset: {fileID: 0}
+  m_GameObject: {fileID: 7443408886575219563}
+  m_Enabled: 1
+  m_EditorHideFlags: 0
+  m_Script: {fileID: 11500000, guid: 6d0962ead4b02a34aae248fccce671ce, type: 3}
+  m_Name: 
+  m_EditorClassIdentifier: 
+  WriteSceneObjectDetails: 0
+  ValidateRpcLengths: 1
+  DisableObserversRpcLinks: 0
+  DisableTargetRpcLinks: 0
+  DisableServerRpcLinks: 0
+  DisableReplicateRpcLinks: 0
+  DisableReconcileRpcLinks: 0

Assets/FishNet/Demos/Prediction/CharacterController/CharacterController Prediction Demo.unity

@@ -279,15 +279,17 @@ MonoBehaviour:
   _controllerMovementSettings:
     EnableTeleport: 0
     TeleportThreshold: 0
-    AdaptiveInterpolationValue: 1
+    AdaptiveInterpolationValue: 4
     InterpolationValue: 2
     SmoothedProperties: 4294967295
+    SnapNonSmoothedProperties: 0
   _spectatorMovementSettings:
     EnableTeleport: 0
     TeleportThreshold: 0
-    AdaptiveInterpolationValue: 1
+    AdaptiveInterpolationValue: 4
     InterpolationValue: 2
     SmoothedProperties: 4294967295
+    SnapNonSmoothedProperties: 0
 --- !u!1 &555580081
 GameObject:
   m_ObjectHideFlags: 0

Assets/FishNet/Demos/Prediction/CharacterController/Prefabs/CharacterControllerPrediction.prefab

@@ -186,7 +186,6 @@ MonoBehaviour:
   _addedNetworkObject: {fileID: 8013474958425823559}
   _networkObjectCache: {fileID: 8013474958425823559}
   _maximumSimultaneousHits: 16
-  _historyDuration: 0.5
   _additionalSize: 0.1
   _layers:
     serializedVersion: 2
@@ -363,12 +362,14 @@ MonoBehaviour:
   _controllerMovementSettings:
     EnableTeleport: 0
     TeleportThreshold: 0
-    AdaptiveInterpolationValue: 1
+    AdaptiveInterpolationValue: 4
     InterpolationValue: 2
     SmoothedProperties: 4294967295
+    SnapNonSmoothedProperties: 0
   _spectatorMovementSettings:
     EnableTeleport: 0
     TeleportThreshold: 0
-    AdaptiveInterpolationValue: 1
+    AdaptiveInterpolationValue: 4
     InterpolationValue: 2
     SmoothedProperties: 4294967295
+    SnapNonSmoothedProperties: 0

Assets/FishNet/Demos/Prediction/CharacterController/Scripts/CharacterControllerPrediction.cs

@@ -302,9 +302,8 @@ private void PerformReplicate(ReplicateData rd, ReplicateState state = Replicate
                  * wrong. If you do however predict wrong often smoothing will cover up the mistake. */
                 else if (state.IsFuture())
                 {
-                    /* Predict up to whatever interpolation is on the PredictionManager. This is the safest way to protect against
-                     * graphical jitter by not predicting beyond global interpolation. */
-                    if (rd.GetTick() - _lastTickedReplicateData.GetTick() >= base.PredictionManager.StateInterpolation)
+                    /* Predict up to 1 tick more. */
+                    if (rd.GetTick() - _lastTickedReplicateData.GetTick() > 1)
                     {
                         useDefaultForces = true;
                     }