Fix #25: PCR is now aware of ThroughTheEyes and cycles correctly when you have an external command chair and a probe core on board

Author: JonnyOThan

ProbeControlRoom/ProbeControlRoom.cs

@@ -321,7 +321,6 @@ public bool startIVA()
                 ProbeControlRoomUtils.Logger.debug("startIVA() - return ACTIVE VESSEL NULL");
                 return false;
             }
-            ProbeControlRoomUtils.Logger.debug("startIVA()");
 
             if (FlightGlobals.ActiveVessel.packed)
             {
@@ -341,6 +340,8 @@ public bool startIVA()
                 return false;
             }
 
+            ProbeControlRoomUtils.Logger.debug("startIVA()");
+
             // spawn the internal model
             if (aPart.internalModel == null)
             {
@@ -502,7 +503,10 @@ public void stopIVA()
 
             // this re-attaches the camera to the internal space, so that it doesn't get deactivated below
             // It's really important that the camera doesn't get deactivated, because then it can't be found again by the stock code
-            InternalCamera.Instance.DisableCamera();
+            if (InternalCamera.Instance.transform.IsChildOf(aPart.internalModel.transform))
+            {
+                InternalCamera.Instance.DisableCamera();
+            }
 
             if (aPart != null && aPart.internalModel != null)
             {
@@ -555,7 +559,7 @@ public void stopIVA()
             InputLockManager.RemoveControlLock("ProbeControlRoom");
 
             //Switch back to normal cameras
-            if (CameraManager.Instance != null && CameraManager.Instance.currentCameraMode == CameraManager.CameraMode.IVA)
+            if (CameraManager.Instance != null && CameraManager.Instance.currentCameraMode == CameraManager.CameraMode.IVA && !ThroughTheEyes.IsFirstPerson)
             {
                 CameraManager.Instance.SetCameraFlight();
             }
@@ -604,6 +608,11 @@ public void LateUpdate()
                     }
                     else
                     {
+                        // if we just pressed C and ThroughTheEyes entered first person, then we should go back to normal flight camera mode to preserve the cycle of flight -> iva -> pcr -> flight
+                        if (ThroughTheEyes.IsFirstPerson)
+                        {
+                            ThroughTheEyes.ExitFirstPerson();
+                        }
 
                         stopIVA();
                     }
@@ -624,7 +633,7 @@ public void LateUpdate()
             else
             {
                 // if pressing the camera mode (C) button and we either failed to enter IVA mode or just left it, then try to start PCR mode
-                if (!GameSettings.MODIFIER_KEY.GetKey() && GameSettings.CAMERA_MODE.GetKeyDown() && CameraManager.Instance.currentCameraMode == CameraManager.CameraMode.Flight)
+                if (!GameSettings.MODIFIER_KEY.GetKey() && GameSettings.CAMERA_MODE.GetKeyDown() && CameraManager.Instance.currentCameraMode == CameraManager.CameraMode.Flight && !ThroughTheEyes.IsFirstPerson)
                 {
                     //if (FlightGlobals.ActiveVessel?.GetCrewCount() == 0)
                     {

ProbeControlRoom/ThroughTheEyes.cs

@@ -0,0 +1,58 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Reflection;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace ProbeControlRoom
+{
+	internal static class ThroughTheEyes
+	{
+		static TypeInfo x_FirstPersonEVA_TypeInfo;
+		static FieldInfo x_instance_FieldInfo;
+		static FieldInfo x_fpCameraManagerFieldInfo;
+
+		static TypeInfo x_FirstPersonCameraManager_TypeInfo;
+		static FieldInfo x_isFirstPerson_FieldInfo;
+		static MethodInfo x_resetCamera_MethodInfo;
+
+		static ThroughTheEyes()
+		{
+			var throughTheEyesAssembly = AssemblyLoader.loadedAssemblies.FirstOrDefault(a => a.assembly.GetName().Name == "ThroughTheEyes");
+			if (throughTheEyesAssembly == null) return;
+
+			x_FirstPersonEVA_TypeInfo = throughTheEyesAssembly.assembly.GetType("FirstPerson.FirstPersonEVA").GetTypeInfo();
+			x_instance_FieldInfo = x_FirstPersonEVA_TypeInfo.GetField("instance", BindingFlags.Static | BindingFlags.Public);
+			x_fpCameraManagerFieldInfo = x_FirstPersonEVA_TypeInfo.GetField("fpCameraManager", BindingFlags.Instance | BindingFlags.Public);
+
+			x_FirstPersonCameraManager_TypeInfo = throughTheEyesAssembly.assembly.GetType("FirstPerson.FirstPersonCameraManager").GetTypeInfo();
+			x_isFirstPerson_FieldInfo = x_FirstPersonCameraManager_TypeInfo.GetField("isFirstPerson", BindingFlags.Instance | BindingFlags.Public);
+			x_resetCamera_MethodInfo = x_FirstPersonCameraManager_TypeInfo.GetMethod("resetCamera", BindingFlags.Instance | BindingFlags.Public);
+		}
+
+		public static bool IsFirstPerson
+		{
+			get
+			{
+				if (x_isFirstPerson_FieldInfo == null)
+				{
+					return false;
+				}
+
+				object firstPersonEVAInstance = x_instance_FieldInfo.GetValue(null);
+				object firstPersonCameraManager = x_fpCameraManagerFieldInfo.GetValue(firstPersonEVAInstance);
+				return (bool)x_isFirstPerson_FieldInfo.GetValue(firstPersonCameraManager);
+			}
+		}
+
+		public static void ExitFirstPerson()
+		{
+			if (x_isFirstPerson_FieldInfo == null) return;
+
+			object firstPersonEVAInstance = x_instance_FieldInfo.GetValue(null);
+			object firstPersonCameraManager = x_fpCameraManagerFieldInfo.GetValue(firstPersonEVAInstance);
+			x_resetCamera_MethodInfo.Invoke(firstPersonCameraManager, new object[] { FlightGlobals.ActiveVessel });
+		}
+	}
+}