restructure optional mods and scatterer install check

Author: JonnyOThan

KerbalVR_Mod/KerbalVR-InstallCheck/InstallCheck.cs

@@ -26,7 +26,6 @@ public class InstallCheck : MonoBehaviour
 		{
 			new Dependency { assemblyName = "EVEManager", minVersion = new Version(1, 11, 7, 1)},
 			new Dependency { assemblyName = "TUFX", minVersion = new Version(1, 0, 5)},
-			new Dependency { assemblyName = "Scatterer", minVersion = new Version(0, 880, 1)},
 			new Dependency { assemblyName = "AvionicsSystems", minVersion = new Version(1, 3, 6)},
 			new Dependency { assemblyName = "RasterPropMonitor", minVersion = new Version(0, 31, 10, 2)},
 		};
@@ -47,6 +46,7 @@ public void Awake()
 			CheckVREnabled();
 			CheckDependencies();
 			CheckOptionalMods();
+			CheckScatterer();
 			CheckRequiredFiles();
 		}
 
@@ -122,6 +122,49 @@ private static void CheckOptionalMods()
 			}
 		}
 
+		// If a given mod exists, checks it against a list of known good versions.
+		// If it's not there, looks up a specific error message for the given version, or else a generic "unsupported" one
+		private static void CheckComplexMappings(string assemblyName, Version[] goodVersions, Dictionary<Version, string> errorMessages)
+		{
+			var assembly = AssemblyLoader.loadedAssemblies.FirstOrDefault(a => a.name == assemblyName);
+			if (assembly == null) return;
+
+			var assemblyVersion = assembly.assembly.GetName().Version;
+
+			// note: not using contains because this is a class and apparently it doesn't compare equal
+			if (goodVersions.IndexOf(assemblyVersion) != -1)
+			{
+				return;
+			}
+			
+			if (errorMessages.TryGetValue(assemblyVersion, out var message))
+			{
+				Alert(message);
+			}
+			else
+			{
+				Alert($"Unsupported {assemblyName} version {assemblyVersion}");
+			}
+		}
+
+		private static void CheckScatterer()
+		{
+			CheckComplexMappings("Scatterer",
+				new Version[]
+				{
+					new Version(0, 851, 0, 0), // volclouds v1
+					new Version(0, 856, 0, 0), // volclouds v2
+					new Version(0, 859, 0, 0), // volclouds v3
+					new Version(0, 878, 1, 0), // VR patch on latest publicly available
+					new Version(0, 880, 1, 0), // VR patch on volumetrics V4
+				},
+				new Dictionary<Version, string>()
+				{
+					{new Version(0, 878, 0, 0), "Install Scatterer from the Optional Mods folder"},
+					{new Version(0, 880, 0, 0), "Install the files from Optional Mods/VolumetricClouds-v4"},
+				});
+		}
+
 		private static void CheckRequiredFiles()
 		{
 			string errorMessage = string.Empty;

KerbalVR_Mod/Optional Mods/README.md

@@ -4,19 +4,14 @@ Install as normal, then copy the Scatterer directory from KerbalVR/Optional Mods
 
 # Volumetric Clouds
 
-If you have blackrack's volumetric clouds, install it as normal and then follow the instructions below according to which version you have.
+If you have blackrack's volumetric clouds, install it as normal.  Then install the contents of one of the KerbalVR/OptionalMods/VolumetricClouds folders into GameData, overwriting any existing files.  Note that VolumetricClouds-v2 is empty; it does not need any special treatment.
 
-## Volumetric Clouds V4 (released December 22 2023)
+For reference, release dates of each version are below:
 
-Copy the EnvironmentalVisualEnhancements and Scatterer folders from the KerbalVR/Optional Mods folder into your GameData directory and overwrite the existing files.
-
-## Volumetric Clouds V3 (released August 26 2023)
-
-Download https://github.com/JonnyOThan/Kerbal-VR/files/12777949/RaymarchedClouds-VR-8.26.23.zip and copy it over your existing EVE install, overwriting the existing files.
-
-## Volumetric Clouds V2 (released May 21 2023)
-
-No additional steps
+ * v1 - January 14, 2023
+ * v2 - May 21 through June 7, 2023
+ * v3 - August 20 through 26, 2023
+ * v4 - December 22, 2023 through July 16, 2024
 
 # Optional VR patches