Fix #82: burn time is nan

JonnyOThan · JonnyOThan · commit 21e2cd115877 · 2023-02-14T16:07:23.000-05:00
diff --git a/RasterPropMonitor/Core/RPMCEvaluators.cs b/RasterPropMonitor/Core/RPMCEvaluators.cs
@@ -947,7 +947,7 @@ internal NumericVariableEvaluator GetNumericEvaluator(string input, out Variable
                     {
                         if (node != null)
                         {
-                            return comp.actualAverageIsp * (1.0f - Math.Exp(-node.GetBurnVector(vessel.orbit).magnitude / comp.actualAverageIsp / RPMGlobals.gee)) / (comp.totalLimitedMaximumThrust / (comp.totalShipWetMass * RPMGlobals.gee));
+                            return JSIInternalRPMButtons.GetBurnDuration((float)node.DeltaV.magnitude);
                         }
                         return double.NaN;
                     };
diff --git a/RasterPropMonitor/Handlers/JSIInternalRPMButtons.cs b/RasterPropMonitor/Handlers/JSIInternalRPMButtons.cs
@@ -1366,7 +1366,7 @@ public bool ButtonSetWarpRailsModeState()
             return TimeWarp.fetch.Mode == TimeWarp.Modes.HIGH;
         }
 
-        double GetBurnDuration(float dv)
+        public static double GetBurnDuration(float dv)
         {
             var vesselDeltaV = FlightGlobals.ActiveVessel.VesselDeltaV;
             double totalDuration = 0;

Original file line number	Diff line number	Diff line change
`@@ -947,7 +947,7 @@ internal NumericVariableEvaluator GetNumericEvaluator(string input, out Variable`
`947`	`947`	`{`
`948`	`948`	`if (node != null)`
`949`	`949`	`{`
`950`		`- return comp.actualAverageIsp * (1.0f - Math.Exp(-node.GetBurnVector(vessel.orbit).magnitude / comp.actualAverageIsp / RPMGlobals.gee)) / (comp.totalLimitedMaximumThrust / (comp.totalShipWetMass * RPMGlobals.gee));`
	`950`	`+ return JSIInternalRPMButtons.GetBurnDuration((float)node.DeltaV.magnitude);`
`951`	`951`	`}`
`952`	`952`	`return double.NaN;`
`953`	`953`	`};`
Original file line number	Diff line number	Diff line change
`@@ -1366,7 +1366,7 @@ public bool ButtonSetWarpRailsModeState()`
`1366`	`1366`	`return TimeWarp.fetch.Mode == TimeWarp.Modes.HIGH;`
`1367`	`1367`	`}`
`1368`	`1368`
`1369`		`- double GetBurnDuration(float dv)`
	`1369`	`+ public static double GetBurnDuration(float dv)`
`1370`	`1370`	`{`
`1371`	`1371`	`var vesselDeltaV = FlightGlobals.ActiveVessel.VesselDeltaV;`
`1372`	`1372`	`double totalDuration = 0;`