Fix #117: lingering font rebuild issue

JonnyOThan · JonnyOThan · commit d0cb5a773847 · 2023-11-10T15:41:42.000-05:00
diff --git a/RasterPropMonitor/Auxiliary modules/PropBatcher.cs b/RasterPropMonitor/Auxiliary modules/PropBatcher.cs
@@ -292,6 +292,7 @@ public void Rebuild()
             public void LateUpdate()
             {
                 if (!needsUpdate) return;
+                needsUpdate = false; // must do this early because regenerating the text can invalidate it again!
 
                 var worldToLocal = batchRoot.transform.worldToLocalMatrix;
                 CombineInstance[] instances = new CombineInstance[textMeshes.Count];
@@ -306,8 +307,6 @@ public void LateUpdate()
                 meshFilter.mesh.Clear();
                 meshFilter.mesh.CombineMeshes(instances);
                 meshFilter.mesh.UploadMeshData(false);
-
-                needsUpdate = false;
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -292,6 +292,7 @@ public void Rebuild()`
`292`	`292`	`public void LateUpdate()`
`293`	`293`	`{`
`294`	`294`	`if (!needsUpdate) return;`
	`295`	`+ needsUpdate = false; // must do this early because regenerating the text can invalidate it again!`
`295`	`296`
`296`	`297`	`var worldToLocal = batchRoot.transform.worldToLocalMatrix;`
`297`	`298`	`CombineInstance[] instances = new CombineInstance[textMeshes.Count];`
`@@ -306,8 +307,6 @@ public void LateUpdate()`
`306`	`307`	`meshFilter.mesh.Clear();`
`307`	`308`	`meshFilter.mesh.CombineMeshes(instances);`
`308`	`309`	`meshFilter.mesh.UploadMeshData(false);`
`309`		`-`
`310`		`- needsUpdate = false;`
`311`	`310`	`}`
`312`	`311`	`}`
`313`	`312`