Fix #79: destroy cameras when the MFD is destroyed

Author: JonnyOThan

RasterPropMonitor/Core/FlyingCamera.cs

@@ -202,29 +202,19 @@ private bool CreateCameraObjects(string newCameraName = null)
             }
         }
 
-        private void CleanupCameraObjects()
+        public void CleanupCameraObjects()
         {
-            if (enabled)
+            for (int i = 0; i < cameraObject.Length; i++)
             {
-                for (int i = 0; i < cameraObject.Length; i++)
+                if (cameraObject[i] != null)
                 {
-                    try
-                    {
-                        UnityEngine.Object.Destroy(cameraObject[i]);
-                        // Analysis disable once EmptyGeneralCatchClause
-                    }
-                    catch
-                    {
-                        // Yes, that's really what it's supposed to be doing.
-                    }
-                    finally
-                    {
-                        cameraObject[i] = null;
-                    }
+                    UnityEngine.Object.Destroy(cameraObject[i]);
                 }
-                enabled = false;
-                //JUtil.LogMessage(this, "Turning camera off.");
+                
+                cameraObject[i] = null;
             }
+
+            enabled = false;
             cameraPart = null;
             cameraTransform = null;
         }

RasterPropMonitor/Handlers/JSISteerableCamera.cs

@@ -394,6 +394,11 @@ public override void OnUpdate()
 
         public void OnDestroy()
         {
+            if (cameraObject != null)
+            {
+                cameraObject.CleanupCameraObjects();
+                cameraObject = null;
+            }
             if (homeCrosshairMaterial != null)
             {
                 UnityEngine.Object.Destroy(homeCrosshairMaterial);