Replace deprecated code and update to 252

Author: PHPirates

.github/workflows/build.yml

@@ -63,8 +63,8 @@ jobs:
       - name: Build Plugin
         run: ./gradlew :plugin:buildPlugin
 
-#      - name: Verify Plugin
-#        run: ./gradlew runPluginVerifier
+      - name: Verify Plugin
+        run: ./gradlew runPluginVerifier
 
       - name: Upload artifact
         uses: actions/upload-artifact@v4

gradle.properties

@@ -1,20 +1,20 @@
 pluginName = intellij-pdf-viewer
 group = com.firsttimeinforever.intellij.pdf.viewer
-version = 0.17.1-alpha.3
+version = 0.17.1-alpha.4
 
 # To run with AS 2021.3.1 Canary 5
 #platformVersion = 213.6777.52
 
 #IntelliJ IDEA 2021.1.2 Preview
-platformVersion = 2025.1
+platformVersion = 2025.2
 pluginSinceVersion = 241
-pluginVerifierIdeVersions = 241, 251
+pluginVerifierIdeVersions = 241, 252
 
-texifyVersion = 0.10.4
+texifyVersion = 0.11.2
 
 kotlinVersion = 2.2.0
 kotlinxSerializationJsonVersion = 1.9.0
-# pdfjs 5 uses URL.parse which is only available in Chrome 126 https://developer.mozilla.org/en-US/docs/Web/API/URL/parse_static#browser_compatibility but intellij 2025.1 still uses JCEF 122 (in Help > About)
+# pdfjs 5 uses URL.parse which is only available in Chrome 126 https://developer.mozilla.org/en-US/docs/Web/API/URL/parse_static#browser_compatibility but intellij 2025.2 still uses JCEF 122 (in Help > About)
 #pdfjsVersion = 5.3.93
 pdfjsVersion = 4.10.38
 

plugin/src/main/kotlin/com/firsttimeinforever/intellij/pdf/viewer/actions/PdfActionUtils.kt

@@ -3,6 +3,7 @@ package com.firsttimeinforever.intellij.pdf.viewer.actions
 import com.intellij.ide.DataManager
 import com.intellij.ide.ui.customization.CustomActionsSchema
 import com.intellij.openapi.actionSystem.*
+import com.intellij.openapi.actionSystem.ex.ActionUtil
 import java.awt.Component
 import javax.swing.JComponent
 
@@ -22,14 +23,16 @@ internal object PdfActionUtils {
 
   fun performAction(action: AnAction, component: Component) {
     val context = DataManager.getInstance().getDataContext(component)
-    action.actionPerformed(
+    ActionUtil.performAction(
+      action,
       AnActionEvent(
-        null,
         context,
-        ActionPlaces.UNKNOWN,
         Presentation(),
-        ActionManager.getInstance(),
-        0
+        ActionPlaces.UNKNOWN,
+        ActionUiKind.TOOLBAR,
+        null,
+        0,
+        ActionManager.getInstance()
       )
     )
   }

plugin/src/main/kotlin/com/firsttimeinforever/intellij/pdf/viewer/actions/PdfToggleAction.kt

@@ -17,7 +17,7 @@ abstract class PdfToggleAction(viewModeAwareness: ViewModeAwareness = ViewModeAw
     base.update(event)
   }
 
-  private inner class StubAction(viewModeAwareness: ViewModeAwareness) : PdfAction(viewModeAwareness) {
+  private class StubAction(viewModeAwareness: ViewModeAwareness) : PdfAction(viewModeAwareness) {
     override fun actionPerformed(event: AnActionEvent) {
       throw IllegalStateException("This method should not be called")
     }

plugin/src/main/kotlin/com/firsttimeinforever/intellij/pdf/viewer/report/PdfErrorReportSubmitter.kt

@@ -1,7 +1,6 @@
 package com.firsttimeinforever.intellij.pdf.viewer.report
 
 import com.firsttimeinforever.intellij.pdf.viewer.PdfViewerBundle
-import com.intellij.diagnostic.IdeaReportingEvent
 import com.intellij.ide.DataManager
 import com.intellij.ide.plugins.IdeaPluginDescriptor
 import com.intellij.idea.IdeaLogger
@@ -42,10 +41,9 @@ internal class PdfErrorReportSubmitter : ErrorReportSubmitter() {
 
   private fun createEvents(events: Array<out IdeaLoggingEvent>, additionalInfo: String?): List<SentryEvent> {
     return events
-      .filterIsInstance<IdeaReportingEvent>()
       .map { ideaEvent ->
         SentryEvent().apply {
-          this.message = Message().apply { this.message = additionalInfo ?: ideaEvent.originalThrowableText }
+          this.message = Message().apply { this.message = additionalInfo ?: ideaEvent.throwableText }
           this.level = SentryLevel.ERROR
           this.throwable = ideaEvent.throwable
 

plugin/src/main/kotlin/com/firsttimeinforever/intellij/pdf/viewer/ui/editor/view/PdfJcefPreviewController.kt

@@ -29,6 +29,7 @@ import com.intellij.openapi.project.Project
 import com.intellij.openapi.util.Disposer
 import com.intellij.openapi.util.registry.Registry
 import com.intellij.openapi.vfs.VirtualFile
+import com.intellij.ui.JBColor
 import com.intellij.ui.jcef.JCEFHtmlPanel
 import com.intellij.util.ui.UIUtil
 import io.netty.handler.codec.http.QueryStringDecoder
@@ -39,7 +40,7 @@ import org.cef.callback.CefContextMenuParams
 import org.cef.callback.CefMenuModel
 import org.cef.handler.CefContextMenuHandlerAdapter
 import java.awt.Color
-import java.net.URL
+import java.net.URI
 import java.util.concurrent.atomic.AtomicBoolean
 
 class PdfJcefPreviewController(val project: Project, val virtualFile: VirtualFile) :
@@ -90,7 +91,7 @@ class PdfJcefPreviewController(val project: Project, val virtualFile: VirtualFil
         if (!viewLoaded || cefBrowser == null) return null
         val urlDecoder = QueryStringDecoder(cefBrowser.url)
         val file = urlDecoder.parameters()?.get("file")?.get(0) ?: return null
-        return URL(URL(cefBrowser.url), file).toString()
+        return URI(cefBrowser.url).resolve(file).toString()
       }
 
       override fun onBeforeContextMenu(cefBrowser: CefBrowser?, frame: CefFrame?, params: CefContextMenuParams?, model: CefMenuModel?) {
@@ -203,9 +204,9 @@ class PdfJcefPreviewController(val project: Project, val virtualFile: VirtualFil
     return when {
       PdfViewerSettings.instance.useCustomColors -> PdfViewerSettings.instance.run {
         ViewTheme.create(
-          Color(customBackgroundColor),
-          Color(customForegroundColor),
-          Color(customIconColor),
+          JBColor(customBackgroundColor, customBackgroundColor),
+          JBColor(customForegroundColor, customForegroundColor),
+          JBColor(customIconColor, customIconColor),
           colorInvertIntensity
         )
       }

plugin/src/main/kotlin/com/firsttimeinforever/intellij/pdf/viewer/ui/editor/view/controls/PdfSearchPanel.kt

@@ -9,6 +9,7 @@ import com.intellij.find.SearchTextArea
 import com.intellij.icons.AllIcons
 import com.intellij.openapi.Disposable
 import com.intellij.openapi.actionSystem.*
+import com.intellij.openapi.actionSystem.ex.ActionUtil
 import com.intellij.openapi.project.DumbAwareAction
 import com.intellij.openapi.project.DumbAwareToggleAction
 import com.intellij.openapi.wm.IdeFocusManager
@@ -56,8 +57,8 @@ class PdfSearchPanel(private val viewComponent: PdfEditorViewComponent): JPanel(
 
   private val findForwardAction = ActionManager.getInstance().getAction("pdf.viewer.FindForwardAction")!!
   private val findBackwardAction = ActionManager.getInstance().getAction("pdf.viewer.FindBackwardAction")!!
-  private val findForwardOnEnterAction = DumbAwareAction.create(findForwardAction::actionPerformed)
-  private val findBackwardOnShiftEnterAction = DumbAwareAction.create(findBackwardAction::actionPerformed)
+  private val findForwardOnEnterAction = DumbAwareAction.create { ActionUtil.performAction(findForwardAction, it) }
+  private val findBackwardOnShiftEnterAction = DumbAwareAction.create { ActionUtil.performAction(findBackwardAction, it) }
 
   init {
     layout = MigLayout("flowx, gap 8, ins 0, fillx, hidemode 3")

…ts/PdfStatusBarProjectManagerListener.kt …i/widgets/PdfStatusBarProjectActivity.ktplugin/src/main/kotlin/com/firsttimeinforever/intellij/pdf/viewer/ui/widgets/PdfStatusBarProjectManagerListener.kt renamed to plugin/src/main/kotlin/com/firsttimeinforever/intellij/pdf/viewer/ui/widgets/PdfStatusBarProjectActivity.kt plugin/src/main/kotlin/com/firsttimeinforever/intellij/pdf/viewer/ui/widgets/PdfStatusBarProjectManagerListener.kt renamed to plugin/src/main/kotlin/com/firsttimeinforever/intellij/pdf/viewer/ui/widgets/PdfStatusBarProjectActivity.kt

@@ -1,22 +1,23 @@
 package com.firsttimeinforever.intellij.pdf.viewer.ui.widgets
 
+import com.intellij.openapi.components.service
 import com.intellij.openapi.diagnostic.logger
 import com.intellij.openapi.fileEditor.FileEditorManagerEvent
 import com.intellij.openapi.fileEditor.FileEditorManagerListener
 import com.intellij.openapi.project.Project
-import com.intellij.openapi.project.ProjectManagerListener
+import com.intellij.openapi.startup.ProjectActivity
 import com.intellij.openapi.wm.impl.status.widget.StatusBarWidgetsManager
 
-internal class PdfStatusBarProjectManagerListener : ProjectManagerListener {
-  override fun projectOpened(project: Project) {
+internal class PdfStatusBarProjectActivity : ProjectActivity {
+  override suspend fun execute(project: Project) {
     logger.debug("Registering new FileEditorManagerListener for newly opened project")
     project.messageBus.connect().subscribe(
       FileEditorManagerListener.FILE_EDITOR_MANAGER,
       object : FileEditorManagerListener {
         override fun selectionChanged(event: FileEditorManagerEvent) {
           logger.debug("Selection changed")
-          val targetFactory = StatusBarWidgetsManager::class.java
-          project.getServiceIfCreated(targetFactory)?.run {
+          @Suppress("IncorrectServiceRetrieving") // Incorrect: PdfStatusBarProjectManagerListener is a project service
+          project.service<StatusBarWidgetsManager>().run {
             logger.debug("Updating widget")
             updateWidget(PdfDocumentPageStatusBarWidgetFactory::class.java)
           }
@@ -26,6 +27,6 @@ internal class PdfStatusBarProjectManagerListener : ProjectManagerListener {
   }
 
   companion object {
-    private val logger = logger<PdfStatusBarProjectManagerListener>()
+    private val logger = logger<PdfStatusBarProjectActivity>()
   }
 }

plugin/src/main/resources/META-INF/plugin.xml

@@ -30,11 +30,10 @@
                             implementation="com.firsttimeinforever.intellij.pdf.viewer.ui.widgets.PdfDocumentPageStatusBarWidgetFactory"/>
 
     <customizableActionGroupProvider implementation="com.firsttimeinforever.intellij.pdf.viewer.actions.PdfCustomizableActionGroupProvider"/>
+    <postStartupActivity implementation="com.firsttimeinforever.intellij.pdf.viewer.ui.widgets.PdfStatusBarProjectActivity"/>
   </extensions>
 
   <applicationListeners>
-    <listener class="com.firsttimeinforever.intellij.pdf.viewer.ui.widgets.PdfStatusBarProjectManagerListener"
-              topic="com.intellij.openapi.project.ProjectManagerListener"/>
     <listener class="com.firsttimeinforever.intellij.pdf.viewer.settings.PdfViewerInvertColorsListener"
               topic="com.intellij.openapi.editor.colors.EditorColorsListener"/>
   </applicationListeners>