Implement cross-platform timeout handling and improve build artifact verification

- Added a cross-platform `run_with_timeout` function in `build.sh` to handle command timeouts on macOS and Linux, enhancing the reliability of executable tests.
- Updated the backend executable tests to utilize the new timeout function, improving error handling for timeouts.
- Enhanced the verification process for build artifacts in the GitHub Actions workflow to ensure either a DMG or app bundle is present, providing clearer error messages and improving build reliability.

These changes improve the robustness of the build and testing processes across different platforms.

Author: Firstp1ck

.github/workflows/release.yml

@@ -588,7 +588,7 @@ jobs:
             exit 1
           fi
           
-          # Check file size
+          # Check file size (macOS uses different stat syntax)
           FILE_SIZE=$(stat -f%z "$BACKEND_EXE")
           FILE_SIZE_MB=$((FILE_SIZE / 1048576))
           echo "Backend executable size: $FILE_SIZE bytes (${FILE_SIZE_MB} MB)"
@@ -605,13 +605,17 @@ jobs:
             chmod +x "$BACKEND_EXE"
           fi
           
-          # Test executable with --help
+          # Test executable with --help (use perl for timeout on macOS since timeout command doesn't exist)
           echo "Testing backend executable with --help..."
-          if timeout 30 "$BACKEND_EXE" --help > /dev/null 2>&1; then
+          if perl -e 'alarm 30; exec @ARGV' "$BACKEND_EXE" --help > /dev/null 2>&1; then
             echo "✓ Backend executable runs successfully"
           else
             EXIT_CODE=$?
-            echo "::warning::Backend executable --help test failed (exit code: $EXIT_CODE)"
+            if [ "$EXIT_CODE" -eq 142 ]; then
+              echo "::warning::Backend executable timed out (30s) - may be hanging"
+            else
+              echo "::warning::Backend executable --help test returned exit code: $EXIT_CODE (non-critical)"
+            fi
           fi
           
           echo "✓ Backend executable verification completed"
@@ -686,21 +690,25 @@ jobs:
         run: |
           echo "=== Building Tauri application ==="
           
-          # Build app bundle first (most reliable on macOS)
-          bunx tauri build --bundles app || {
-            echo "::warning::App bundle build had issues"
+          # Build both app bundle and DMG together
+          # Note: DMG bundler may clean up the .app after creating DMG
+          bunx tauri build --bundles app,dmg 2>&1 || {
+            echo "::warning::Some bundle builds may have had issues"
           }
           
-          # Try to build DMG (may fail due to AppleScript permissions in CI)
-          bunx tauri build --bundles dmg 2>&1 || {
-            echo "::warning::DMG build failed (common in CI due to AppleScript permissions)"
-          }
+          # Check if either app bundle or DMG was created (DMG is the primary deliverable)
+          BUNDLE_DIR="src-tauri/target/release/bundle"
+          APP_BUNDLE="$BUNDLE_DIR/macos/Budget Planer.app"
+          DMG_FILE=$(find "$BUNDLE_DIR" -name "*.dmg" 2>/dev/null | head -1)
           
-          # Check if app bundle was created
-          if [ -d "src-tauri/target/release/bundle/macos/Budget Planer.app" ]; then
-            echo "✓ App bundle created successfully"
+          if [ -n "$DMG_FILE" ] && [ -f "$DMG_FILE" ]; then
+            echo "✓ DMG created successfully: $DMG_FILE"
+          elif [ -d "$APP_BUNDLE" ]; then
+            echo "✓ App bundle created successfully (DMG creation may have failed)"
           else
-            echo "::error::App bundle not found - build failed"
+            echo "::error::Neither DMG nor app bundle found - build failed"
+            echo "Contents of bundle directory:"
+            find "$BUNDLE_DIR" -type f 2>/dev/null || echo "Bundle directory not found"
             exit 1
           fi
           
@@ -728,23 +736,35 @@ jobs:
           echo ""
           echo "Bundle artifacts:"
           
-          # App bundle
-          if [ -d "$BUNDLE_DIR/macos/Budget Planer.app" ]; then
-            SIZE=$(du -sm "$BUNDLE_DIR/macos/Budget Planer.app" | cut -f1)
-            echo "✓ App bundle: $BUNDLE_DIR/macos/Budget Planer.app (${SIZE} MB)"
-          else
-            echo "::error::App bundle not found"
-            exit 1
-          fi
+          HAS_DISTRIBUTABLE=false
           
-          # DMG
+          # DMG (primary distributable for macOS)
           DMG=$(find "$BUNDLE_DIR" -name "*.dmg" 2>/dev/null | head -1)
           if [ -n "$DMG" ] && [ -f "$DMG" ]; then
             SIZE=$(stat -f%z "$DMG")
             echo "✓ DMG: $DMG ($((SIZE / 1048576)) MB)"
+            HAS_DISTRIBUTABLE=true
           else
-            echo "⚠ DMG: not found (may have failed due to CI limitations)"
+            echo "⚠ DMG: not found"
           fi
+          
+          # App bundle (may be cleaned up after DMG creation)
+          if [ -d "$BUNDLE_DIR/macos/Budget Planer.app" ]; then
+            SIZE=$(du -sm "$BUNDLE_DIR/macos/Budget Planer.app" | cut -f1)
+            echo "✓ App bundle: $BUNDLE_DIR/macos/Budget Planer.app (${SIZE} MB)"
+            HAS_DISTRIBUTABLE=true
+          else
+            echo "⚠ App bundle: not found (may have been cleaned up after DMG creation)"
+          fi
+          
+          # Fail only if we have no distributable artifacts
+          if [ "$HAS_DISTRIBUTABLE" = false ]; then
+            echo "::error::No distributable artifacts found (neither DMG nor app bundle)"
+            exit 1
+          fi
+          
+          echo ""
+          echo "✓ macOS build verification passed"
 
       - name: Upload macOS artifacts
         uses: actions/upload-artifact@v4
@@ -757,7 +777,7 @@ jobs:
             frontend/src-tauri/target/release/bundle/**/*.pkg
             frontend/src-tauri/resources/backend-server
             backend/dist/backend-server
-          if-no-files-found: error
+          if-no-files-found: warn
 
   publish-release:
     name: Publish Release

build.sh

@@ -136,6 +136,23 @@ command_exists() {
     command -v "$1" >/dev/null 2>&1
 }
 
+# Cross-platform timeout function (macOS doesn't have timeout by default)
+run_with_timeout() {
+    local timeout_seconds="$1"
+    shift
+    
+    if command_exists timeout; then
+        # Linux - use timeout command
+        timeout "$timeout_seconds" "$@"
+    elif command_exists gtimeout; then
+        # macOS with coreutils installed
+        gtimeout "$timeout_seconds" "$@"
+    else
+        # Fallback: use perl for timeout (available on macOS)
+        perl -e "alarm $timeout_seconds; exec @ARGV" "$@"
+    fi
+}
+
 # Function to get file size in human readable format
 get_file_size() {
     local file="$1"
@@ -198,11 +215,11 @@ test_backend_executable() {
 
     # Test with --help flag
     print_info "Testing executable with --help flag..."
-    if timeout 30 "$exe_path" --help > /dev/null 2>&1; then
+    if run_with_timeout 30 "$exe_path" --help > /dev/null 2>&1; then
         print_success "Executable runs successfully with --help"
     else
         local exit_code=$?
-        if [ "$exit_code" -eq 124 ]; then
+        if [ "$exit_code" -eq 124 ] || [ "$exit_code" -eq 142 ]; then
             print_warning "Executable timed out (30s) - may be hanging or stuck"
         else
             print_warning "Executable --help test returned exit code: $exit_code"
@@ -212,7 +229,7 @@ test_backend_executable() {
 
     # Try to get version/import test
     print_info "Testing Django import..."
-    if timeout 30 "$exe_path" --port 0 2>&1 | head -5 | grep -qi "django\|server\|starting" 2>/dev/null; then
+    if run_with_timeout 30 "$exe_path" --port 0 2>&1 | head -5 | grep -qi "django\|server\|starting" 2>/dev/null; then
         print_success "Django imports appear to work"
     else
         print_warning "Could not verify Django imports (may still work)"
@@ -345,22 +362,31 @@ verify_build_artifacts() {
                 fi
 
             elif [ "$PLATFORM" == "macos" ]; then
-                # App bundle
+                local has_distributable=false
+                
+                # DMG (primary distributable for macOS)
+                DMG_FILE=$(find "$BUNDLE_DIR" -name "*.dmg" 2>/dev/null | head -1)
+                if [ -n "$DMG_FILE" ] && [ -f "$DMG_FILE" ]; then
+                    print_success "DMG: $(basename "$DMG_FILE") ($(get_file_size "$DMG_FILE"))"
+                    has_distributable=true
+                else
+                    print_warning "DMG not found"
+                fi
+                
+                # App bundle (may be cleaned up after DMG creation)
                 APP_BUNDLE=$(find "$BUNDLE_DIR" -name "*.app" -type d 2>/dev/null | head -1)
                 if [ -n "$APP_BUNDLE" ] && [ -d "$APP_BUNDLE" ]; then
                     local size=$(du -sh "$APP_BUNDLE" 2>/dev/null | cut -f1)
                     print_success "App bundle: $(basename "$APP_BUNDLE") ($size)"
+                    has_distributable=true
                 else
-                    print_error "App bundle not found"
-                    all_ok=false
+                    print_warning "App bundle not found (may have been cleaned up after DMG creation)"
                 fi
 
-                # DMG
-                DMG_FILE=$(find "$BUNDLE_DIR" -name "*.dmg" 2>/dev/null | head -1)
-                if [ -n "$DMG_FILE" ] && [ -f "$DMG_FILE" ]; then
-                    print_success "DMG: $(basename "$DMG_FILE") ($(get_file_size "$DMG_FILE"))"
-                else
-                    print_warning "DMG not found"
+                # Fail only if no distributable exists
+                if [ "$has_distributable" = false ]; then
+                    print_error "No distributable artifacts found (neither DMG nor app bundle)"
+                    all_ok=false
                 fi
 
             elif [ "$PLATFORM" == "windows" ]; then