feat(EnchantManager): Enchantment Lore Parsing's Highlight Enchantments now supports RGB colors instead of just restricted colors

feat: migrate hardcoded § tooltip strings to Component with translation keys
perf: cache first tooltip components by ItemStack reference equality
fix(PlayerListener): skip enchantment lore lines during Roman numeral replacement
fix: improved text replacement for Enchantment and Roman Numerals Parsing
refactor: EnchantmentSettingsGui removed, merged into SettingsGui
refactor(EnchantManager): migrate enchant formatting from § strings to Component
refactor(RomanNumeralParser): replace string-based numeral replacement with Component-aware approach

Author: Fix3dll

src/main/java/com/fix3dll/skyblockaddons/core/feature/FeatureSetting.java

@@ -71,15 +71,15 @@ public enum FeatureSetting {
     SHOW_SKILL_XP_GAINED("settings.showSkillXPGained", Feature.SKILL_DISPLAY),
     SHOW_SALVAGE_ESSENCES_COUNTER("settings.showSalvageEssencesCounter", Feature.DUNGEONS_COLLECTED_ESSENCES_DISPLAY),
     HEALING_CIRCLE_OPACITY("settings.healingCircleOpacity", Feature.SHOW_HEALING_CIRCLE_WALL),
+    HIDE_ENCHANTMENT_LORE("settings.hideEnchantDescription", Feature.ENCHANTMENT_LORE_PARSING),
+    HIDE_GREY_ENCHANTS("settings.hideGreyEnchants", Feature.ENCHANTMENT_LORE_PARSING),
+    ENCHANT_LAYOUT("enchantLayout.title", Feature.ENCHANTMENT_LORE_PARSING),
     HIGHLIGHT_ENCHANTMENTS("settings.highlightSpecialEnchantments", Feature.ENCHANTMENT_LORE_PARSING),
     PERFECT_ENCHANT_COLOR("enchants.superTier", Feature.ENCHANTMENT_LORE_PARSING),
     GREAT_ENCHANT_COLOR("enchants.highTier", Feature.ENCHANTMENT_LORE_PARSING),
     GOOD_ENCHANT_COLOR("enchants.midTier", Feature.ENCHANTMENT_LORE_PARSING),
     POOR_ENCHANT_COLOR("enchants.lowTier", Feature.ENCHANTMENT_LORE_PARSING),
     COMMA_ENCHANT_COLOR("enchants.commas", Feature.ENCHANTMENT_LORE_PARSING),
-    HIDE_ENCHANTMENT_LORE("settings.hideEnchantDescription", Feature.ENCHANTMENT_LORE_PARSING),
-    HIDE_GREY_ENCHANTS("settings.hideGreyEnchants", Feature.ENCHANTMENT_LORE_PARSING),
-    ENCHANT_LAYOUT("enchantLayout.title", Feature.ENCHANTMENT_LORE_PARSING),
     TREVOR_TRACKED_ENTITY_PROXIMITY_INDICATOR("settings.trevorTheTrapper.trackedEntityProximityIndicator", Feature.TREVOR_THE_TRAPPER_FEATURES),
     TREVOR_HIGHLIGHT_TRACKED_ENTITY("settings.trevorTheTrapper.highlightTrackedEntity", Feature.TREVOR_THE_TRAPPER_FEATURES),
     TREVOR_SHOW_QUEST_COOLDOWN("settings.trevorTheTrapper.showQuestCooldown", Feature.TREVOR_THE_TRAPPER_FEATURES),

src/main/java/com/fix3dll/skyblockaddons/features/enchants/EnchantManager.java

@@ -1,7 +1,6 @@
 package com.fix3dll.skyblockaddons.gui.buttons;
 
 import com.fix3dll.skyblockaddons.SkyblockAddons;
-import com.fix3dll.skyblockaddons.gui.screens.EnchantmentSettingsGui;
 import com.fix3dll.skyblockaddons.gui.screens.SettingsGui;
 import com.fix3dll.skyblockaddons.gui.screens.SkyblockAddonsGui;
 import com.fix3dll.skyblockaddons.utils.EnumUtils;
@@ -58,13 +57,6 @@ public void onClick(@NonNull MouseButtonEvent event, boolean isDoubleClick) {
                 MC.setScreen(new SkyblockAddonsGui(page, gui.getTab()));
 
                 if (gui.getTab() == EnumUtils.GuiTab.GENERAL_SETTINGS) gui.setCancelClose(false);
-
-            } else if (MC.screen instanceof EnchantmentSettingsGui gui) {
-                gui.setClosingGui(true);
-
-                int page = gui.getPage() + (arrowType == ArrowType.LEFT ? -1 : +1);
-                MC.setScreen(new EnchantmentSettingsGui(page, gui.getLastPage(), gui.getLastTab()));
-
             } else if (MC.screen instanceof SettingsGui gui) {
                 gui.setClosingGui(true);
 

src/main/java/com/fix3dll/skyblockaddons/gui/buttons/ButtonArrow.java

@@ -2,7 +2,6 @@
 
 import com.fix3dll.skyblockaddons.SkyblockAddons;
 import com.fix3dll.skyblockaddons.core.feature.Feature;
-import com.fix3dll.skyblockaddons.gui.screens.EnchantmentSettingsGui;
 import com.fix3dll.skyblockaddons.gui.screens.SettingsGui;
 import com.fix3dll.skyblockaddons.gui.screens.SkyblockAddonsGui;
 import com.fix3dll.skyblockaddons.utils.EnumUtils.GUIType;
@@ -42,14 +41,10 @@ public void renderWidget(GuiGraphics graphics, int mouseX, int mouseY, float par
     public void onClick(@NonNull MouseButtonEvent event, boolean isDoubleClick) {
         if (MC.screen instanceof SkyblockAddonsGui gui) {
             main.getUtils().setFadingIn(false);
-            if (this.feature == Feature.ENCHANTMENT_LORE_PARSING) {
-                MC.setScreen(new EnchantmentSettingsGui(0, gui.getPage(), gui.getTab()));
-            } else {
-                boolean generalSettings = gui.getTab() == GuiTab.GENERAL_SETTINGS;
-                if (generalSettings) gui.setCancelClose(true);
-                MC.setScreen(new SettingsGui(this.feature, 1, gui.getPage(), gui.getTab(), GUIType.MAIN));
-                if (generalSettings) gui.setCancelClose(false);
-            }
+            boolean generalSettings = gui.getTab() == GuiTab.GENERAL_SETTINGS;
+            if (generalSettings) gui.setCancelClose(true);
+            MC.setScreen(new SettingsGui(this.feature, 1, gui.getPage(), gui.getTab(), GUIType.MAIN));
+            if (generalSettings) gui.setCancelClose(false);
         }
     }
 

src/main/java/com/fix3dll/skyblockaddons/gui/buttons/feature/ButtonSettings.java

@@ -8,6 +8,7 @@
 import com.fix3dll.skyblockaddons.core.feature.FeatureSetting;
 import com.fix3dll.skyblockaddons.features.discordrpc.DiscordStatus;
 import com.fix3dll.skyblockaddons.features.dungeonmap.DungeonMapManager;
+import com.fix3dll.skyblockaddons.features.enchants.EnchantLayout;
 import com.fix3dll.skyblockaddons.gui.buttons.ButtonArrow;
 import com.fix3dll.skyblockaddons.gui.buttons.ButtonCycling;
 import com.fix3dll.skyblockaddons.gui.buttons.ButtonInputFieldWrapper;
@@ -480,6 +481,30 @@ private void addButton(FeatureSetting setting, Object settingValue) {
                 if (setting == FeatureSetting.TANK_COLOR) row += 0.4F; // Last spacing
                 break;
 
+            case PERFECT_ENCHANT_COLOR:
+            case GREAT_ENCHANT_COLOR:
+            case GOOD_ENCHANT_COLOR:
+            case POOR_ENCHANT_COLOR:
+            case COMMA_ENCHANT_COLOR:
+                boxWidth = 100;
+                x = halfWidth - (boxWidth / 2);
+                y = getRowHeightSetting(row);
+                addRenderableWidget(new ButtonOpenColorMenu(x, y, 100, 20, setting.getMessage(), setting));
+                if (setting == FeatureSetting.COMMA_ENCHANT_COLOR) row += 0.4F; // Last spacing
+                break;
+
+            case ENCHANT_LAYOUT:
+                boxWidth = 140;
+                x = halfWidth - (boxWidth / 2);
+                addRenderableWidget(new ButtonText(halfWidth, (int) y - 10, Translations.getMessage("enchantLayout.title"), true, 0xFFFFFFFF));
+                addRenderableWidget(new ButtonCycling(x, (int) y, boxWidth, 20,
+                        Arrays.asList(EnchantLayout.values()),
+                        feature.getAsEnum(setting).ordinal(),
+                        index -> feature.set(setting, EnchantLayout.values()[index])
+                ));
+                row += 0.5F;
+                break;
+
             case BAZAAR_PRICES_UPDATE_INTERVAL:
                 boxWidth = 150;
                 x = halfWidth - (boxWidth / 2);