Fix PeriodicallyFlushingMemoryHandler inhibiting application shutdown (matrix-org#10517)

reivilibre · web-flow · commit 903db99ed552 · 2021-08-03T14:28:30.000+01:00
diff --git a/changelog.d/10517.bugfix b/changelog.d/10517.bugfix
@@ -0,0 +1 @@
+Fix the `PeriodicallyFlushingMemoryHandler` inhibiting application shutdown because of its background thread.
diff --git a/synapse/logging/handlers.py b/synapse/logging/handlers.py
@@ -45,6 +45,7 @@ def __init__(
         self._flushing_thread: Thread = Thread(
             name="PeriodicallyFlushingMemoryHandler flushing thread",
             target=self._flush_periodically,
+            daemon=True,
         )
         self._flushing_thread.start()
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fix the `PeriodicallyFlushingMemoryHandler` inhibiting application shutdown because of its background thread.
Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,7 @@ def __init__(`
`45`	`45`	`self._flushing_thread: Thread = Thread(`
`46`	`46`	`name="PeriodicallyFlushingMemoryHandler flushing thread",`
`47`	`47`	`target=self._flush_periodically,`
	`48`	`+ daemon=True,`
`48`	`49`	`)`
`49`	`50`	`self._flushing_thread.start()`
`50`	`51`