Skip to content

Commit ce593e3

Browse files
committed
feat: removed-redundant-comments
1 parent 7ec497f commit ce593e3

File tree

2 files changed

+2
-18
lines changed

2 files changed

+2
-18
lines changed

src/edge_proxy/environments.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
def _filter_disabled_flags(
3333
flags: list[dict[str, Any]], hide_disabled_flags: bool
3434
) -> list[dict[str, Any]]:
35-
"""Filter out disabled flags if hide_disabled_flags is enabled."""
3635
if not hide_disabled_flags:
3736
return flags
3837
return [flag for flag in flags if flag.get("enabled", False)]
@@ -93,20 +92,15 @@ def get_flags_response_data(
9392
"hide_disabled_flags", False
9493
)
9594

96-
# Build evaluation context from environment document
9795
context = map_environment_document_to_context(environment_document)
98-
99-
# Get evaluation result
10096
evaluation_result = get_evaluation_result(context)
10197

10298
if feature:
103-
# Get specific feature
10499
if feature not in evaluation_result["flags"]:
105100
raise FeatureNotFoundError()
106101

107102
flag_result = evaluation_result["flags"][feature]
108103

109-
# Filter server-key-only features if not a server key
110104
if not is_server_key:
111105
filtered = filter_out_server_key_only_flags(
112106
[flag_result], server_key_only_feature_ids
@@ -117,18 +111,14 @@ def get_flags_response_data(
117111
data = map_flag_result_to_response_data(flag_result)
118112

119113
else:
120-
# Get all features
121114
flags = list(evaluation_result["flags"].values())
122115

123-
# Filter server-key-only features if not a server key
124116
if not is_server_key:
125117
flags = filter_out_server_key_only_flags(
126118
flags, server_key_only_feature_ids
127119
)
128120

129-
# Filter disabled flags if hide_disabled_flags is enabled
130121
flags = _filter_disabled_flags(flags, hide_disabled_flags)
131-
132122
data = map_flag_results_to_response_data(flags)
133123

134124
return data
@@ -145,25 +135,19 @@ def get_identity_response_data(
145135
"hide_disabled_flags", False
146136
)
147137

148-
# Build evaluation context from environment document
149138
context = map_environment_document_to_context(environment_document)
150-
151-
# Add identity to context
152139
context = map_context_and_identity_data_to_context(
153140
context=context,
154141
identifier=input_data.identifier,
155142
traits=input_data.traits,
156143
)
157144

158-
# Get evaluation result
159145
evaluation_result = get_evaluation_result(context)
160146

161-
# Filter server-key-only features if not a server key
162147
flags = list(evaluation_result["flags"].values())
163148
if not is_server_key:
164149
flags = filter_out_server_key_only_flags(flags, server_key_only_feature_ids)
165150

166-
# Filter disabled flags if hide_disabled_flags is enabled
167151
flags = _filter_disabled_flags(flags, hide_disabled_flags)
168152

169153
data = {

src/edge_proxy/models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ class IdentityWithTraits(BaseModel):
1111
@field_validator("traits", mode="before")
1212
@classmethod
1313
def convert_traits_list_to_dict(cls, v: Any) -> dict[str, ContextValue]:
14-
"""Convert traits from list format to dict format for backward compatibility."""
14+
"""Convert legacy list format to dict."""
1515
if isinstance(v, list):
1616
return {trait["trait_key"]: trait["trait_value"] for trait in v}
1717
return v
@@ -21,7 +21,7 @@ def convert_traits_list_to_dict(cls, v: Any) -> dict[str, ContextValue]:
2121
def validate_trait_value_length(
2222
cls, v: dict[str, ContextValue]
2323
) -> dict[str, ContextValue]:
24-
"""Validate that trait values don't exceed 2000 characters."""
24+
"""Enforce 2000 char limit on trait values."""
2525
for key, value in v.items():
2626
if isinstance(value, str) and len(value) > 2000:
2727
raise PydanticCustomError(

0 commit comments

Comments
 (0)