fix: reviewed-validation-to-delete-metadata-without-value

Author: Zaimwa9

src/common/metadata/serializers.py

@@ -15,13 +15,16 @@
 
 
 class MetadataSerializer(serializers.ModelSerializer["Metadata"]):
+    field_value = serializers.CharField(required=False, allow_blank=True, allow_null=True)
+
     class Meta:
         model = apps.get_model("metadata", "Metadata")
         fields = ("id", "model_field", "field_value")
 
     def validate(self, data: dict[str, typing.Any]) -> dict[str, typing.Any]:
         data = super().validate(data)
-        if not data["model_field"].field.is_field_value_valid(data["field_value"]):
+        field_value = data.get("field_value")
+        if (field_value and not data["model_field"].field.is_field_value_valid(field_value)):
             raise serializers.ValidationError(
                 f"Invalid value for field {data['model_field'].field.name}"
             )
@@ -74,7 +77,7 @@ def update_metadata(
 
         for metadata_item in metadata_data:
             metadata_model_field = metadata_item.pop("model_field", None)
-            if metadata_item.get("delete"):
+            if metadata_item.get("delete") or not metadata_item.get("field_value"):
                 Metadata.objects.filter(
                     model_field=metadata_model_field,
                     object_id=instance.pk,
@@ -113,7 +116,7 @@ def validate_required_metadata(
             if required_for.pk == requirement.object_id:
                 if not any(
                     [
-                        field["model_field"] == requirement.model_field
+                        field["model_field"] == requirement.model_field and field.get("field_value") not in [None, ""]
                         for field in metadata
                     ]
                 ):