Fix tests again ✨

Author: emyller

src/common/core/middleware.py

@@ -2,7 +2,7 @@
 
 from django.http import HttpRequest, HttpResponse
 
-from common.core.utils import get_versions_from_manifest
+from common.core.utils import UNKNOWN, get_versions_from_manifest
 
 
 class APIResponseVersionHeaderMiddleware:
@@ -18,10 +18,11 @@ def __init__(
 
     def __call__(self, request: HttpRequest) -> HttpResponse:
         response = self.get_response(request)
-        response.headers["X-Flagsmith-Version"] = self.get_version() or "unknown"
+        response.headers["X-Flagsmith-Version"] = self.get_version()
         return response
 
-    def get_version(self) -> str | None:
+    def get_version(self) -> str:
         """Obtains the version number from the manifest file"""
         manifest_versions = get_versions_from_manifest()
-        return manifest_versions["."]
+        version: str = manifest_versions.get(".") or UNKNOWN
+        return version

tests/unit/common/core/test_middleware.py

@@ -1,7 +1,13 @@
 import pytest
 from pytest_mock import MockerFixture
 
-from common.core import middleware as middleware_module
+from common.core import middleware as middleware_module, utils
+
+
+@pytest.fixture(autouse=True)
+def clear_lru_caches() -> None:
+    utils.get_file_contents.cache_clear()
+    utils.get_versions_from_manifest.cache_clear()
 
 
 def test_APIResponseVersionHeaderMiddleware__valid_version_info___adds_version_header(
@@ -28,8 +34,8 @@ def test_APIResponseVersionHeaderMiddleware__valid_version_info___adds_version_h
 
 
 @pytest.mark.parametrize("version_info", [
+    {"foo": "bar"},
     {},
-    None,
 ])
 def test_APIResponseVersionHeaderMiddleware__invalid_version_info___adds_unknown_header(
     mocker: MockerFixture,

tests/unit/common/core/test_utils.py

@@ -91,6 +91,7 @@ def test_get_version_info_with_missing_files(fs: FakeFilesystem) -> None:
         "has_email_provider": False,
         "is_enterprise": True,
         "is_saas": False,
+        'package_versions': {'.': 'unknown'},
         "self_hosted_data": {
             "has_logins": False,
             "has_users": False,