refactor: remove unused JsonFormatter class

No production consumer — all JSON formatting goes through
map_event_to_json_record via structlog's ProcessorFormatter.
JsonRecord TypedDict stays as the schema definition.

Author: khvn26

src/common/core/logging.py

@@ -15,6 +15,7 @@
 from typing_extensions import TypedDict
 
 from common.core.constants import LOGGING_DEFAULT_ROOT_LOG_LEVEL
+from common.core.sentry import sentry_processor
 
 logger = logging.getLogger(__name__)
 
@@ -29,27 +30,6 @@ class JsonRecord(TypedDict, extra_items=Any, total=False):  # type: ignore[call-
     exc_info: str
 
 
-class JsonFormatter(logging.Formatter):
-    """Custom formatter for json logs."""
-
-    def get_json_record(self, record: logging.LogRecord) -> JsonRecord:
-        formatted_message = record.getMessage()
-        json_record: JsonRecord = {
-            "levelname": record.levelname,
-            "message": formatted_message,
-            "timestamp": self.formatTime(record, self.datefmt),
-            "logger_name": record.name,
-            "pid": record.process,
-            "thread_name": record.threadName,
-        }
-        if record.exc_info:
-            json_record["exc_info"] = self.formatException(record.exc_info)
-        return json_record
-
-    def format(self, record: logging.LogRecord) -> str:
-        return json.dumps(self.get_json_record(record))
-
-
 def setup_logging(
     log_level: str = "INFO",
     log_format: str = "generic",
@@ -120,7 +100,7 @@ def map_event_to_json_record(
     method_name: str,
     event_dict: EventDict,
 ) -> EventDict:
-    """Map structlog fields to match :class:`JsonFormatter` output schema."""
+    """Map structlog fields to match :class:`JsonRecord` output schema."""
     event_dict.pop("positional_args", None)
     record: JsonRecord = {
         "message": event_dict.pop("event", ""),
@@ -148,7 +128,6 @@ def setup_structlog(
     record, leaving the original ``msg``, ``args``, and ``exc_info``
     intact for Sentry's ``LoggingIntegration`` hook.
     """
-    from common.core.sentry import sentry_processor
 
     if log_format == "json":
         renderer_processors: list[Processor] = [

tests/unit/common/core/test_logging.py

@@ -11,7 +11,7 @@
 from sentry_sdk.envelope import Envelope
 from sentry_sdk.transport import Transport
 
-from common.core.logging import JsonFormatter, setup_logging
+from common.core.logging import setup_logging
 
 if TYPE_CHECKING:
     from sentry_sdk._types import Event
@@ -49,61 +49,6 @@ def sentry_transport_mock() -> Generator[MockSentryTransport, None, None]:
     sentry_sdk.init(transport=None)
 
 
-@pytest.mark.freeze_time("2023-12-08T06:05:47+00:00")
-def test_json_formatter__format_log__outputs_expected(
-    caplog: pytest.LogCaptureFixture,
-    request: pytest.FixtureRequest,
-) -> None:
-    # Given
-    json_formatter = JsonFormatter()
-
-    caplog.handler.setFormatter(json_formatter)
-    logger = logging.getLogger("test_json_formatter__outputs_expected")
-    logger.setLevel(logging.INFO)
-
-    expected_pid = os.getpid()
-    expected_module_path = os.path.abspath(request.path)
-
-    def _log_traceback() -> None:
-        try:
-            raise Exception()
-        except Exception as exc:
-            logger.error("this is an error", exc_info=exc)
-
-    expected_lineno = _log_traceback.__code__.co_firstlineno + 2
-    expected_tb_string = (
-        "Traceback (most recent call last):\n"
-        f'  File "{expected_module_path}",'
-        f" line {expected_lineno}, in _log_traceback\n"
-        "    raise Exception()\nException"
-    )
-
-    # When
-    logger.info("hello %s, %d", "arg1", 22.22)
-    _log_traceback()
-
-    # Then
-    assert [json.loads(message) for message in caplog.text.split("\n") if message] == [
-        {
-            "levelname": "INFO",
-            "message": "hello arg1, 22",
-            "timestamp": "2023-12-08 06:05:47,000",
-            "logger_name": "test_json_formatter__outputs_expected",
-            "pid": expected_pid,
-            "thread_name": "MainThread",
-        },
-        {
-            "levelname": "ERROR",
-            "message": "this is an error",
-            "timestamp": "2023-12-08 06:05:47,000",
-            "logger_name": "test_json_formatter__outputs_expected",
-            "pid": expected_pid,
-            "thread_name": "MainThread",
-            "exc_info": expected_tb_string,
-        },
-    ]
-
-
 def test_setup_logging__generic_format__configures_stdlib(
     capsys: pytest.CaptureFixture[str],
     test_app_loggers: list[str],