Remove legacy engine code

Co-authored-by: Claude <noreply@anthropic.com>

Author: emyller

Flagsmith.Client.Test/FlagsmithTest.cs

@@ -124,7 +124,7 @@ public async Task TestGetEnvironmentFlagsUsesLocalEnvironmentWhenAvailable()
             var flags = (await flagsmithClientTest.GetEnvironmentFlags()).AllFlags();
             var fs = Fixtures.Environment.FeatureStates[0];
             Assert.Equal(fs.Enabled, flags[0].Enabled);
-            Assert.Equal(fs.GetValue(), flags[0].Value);
+            Assert.Equal(fs.Value, flags[0].Value);
             Assert.Equal(fs.Feature.Name, flags[0].GetFeatureName());
             mockHttpClient.VerifyHttpRequest(HttpMethod.Get, "/api/v1/environment-document/", Times.Once);
         }

Flagsmith.Engine/Feature/Models/FeatureStateModel.cs

@@ -1,8 +1,5 @@
 using Newtonsoft.Json;
-using System;
 using System.Collections.Generic;
-using System.Text;
-using FlagsmithEngine.Utils;
 using System.Linq;
 using System.Runtime.Serialization;
 using FlagsmithEngine.Exceptions;
@@ -11,8 +8,6 @@ namespace FlagsmithEngine.Feature.Models
 {
     public class FeatureStateModel
     {
-        public Hashing Hashing = new Hashing();
-
         [JsonProperty(PropertyName = "feature")]
         public FeatureModel Feature { get; set; }
         [JsonProperty(PropertyName = "enabled")]
@@ -23,45 +18,11 @@ public class FeatureStateModel
         public List<MultivariateFeatureStateValueModel> MultivariateFeatureStateValues { get; set; }
         [JsonProperty(PropertyName = "django_id")]
         public int? DjangoId { get; set; }
-        public string FeatureStateUUID { get; set; } = new Guid().ToString();
+        [JsonProperty(PropertyName = "featurestate_uuid")]
+        public string FeatureStateUUID { get; set; }
         [JsonProperty(PropertyName = "feature_segment")]
         public FeatureSegmentModel FeatureSegment { get; set; } = null;
-        public object GetValue(string identityId = null) =>
-            identityId != null && MultivariateFeatureStateValues?.Count > 0 ? GetMultivariateValue(identityId.ToString()) : Value;
-
-        public object GetMultivariateValue(string identityId)
-        {
-            var percentageValue = Hashing.GetHashedPercentageForObjectIds(new List<string>
-            {
-              DjangoId != null ? DjangoId.ToString() : FeatureStateUUID,
-              identityId.ToString()
-            });
-            var startPercentage = 0.0;
-            foreach (var myValue in MultivariateFeatureStateValues.OrderBy(m => m.Id))
-            {
-                var limit = myValue.PercentageAllocation + startPercentage;
-                if (startPercentage <= percentageValue && percentageValue < limit)
-                    return myValue.MultivariateFeatureOption.Value;
-                startPercentage = limit;
-            }
-            return Value;
-        }
 
-        /// <summary>
-        /// Another FeatureStateModel is deemed to be higher priority if and only if 
-        /// it has a FeatureSegment and either this.FeatureSegment is null or the 
-        /// value of other.FeatureSegment.priority is lower than that of 
-        /// this.FeatureSegment.priority. 
-        /// </summary>
-        public bool IsHigherPriority(FeatureStateModel other)
-        {
-            if (this.FeatureSegment == null || other.FeatureSegment == null)
-            {
-                return this.FeatureSegment != null && other.FeatureSegment == null;
-            }
-
-            return this.FeatureSegment.Priority < other.FeatureSegment.Priority;
-        }
         [OnSerialized()]
         private void ValidatePercentageAllocations(StreamingContext _)
         {

Flagsmith.Engine/Identity/Models/IdentityModel.cs

@@ -1,43 +1,15 @@
-using FlagsmithEngine.Trait.Models;
 using System;
 using System.Collections.Generic;
-using System.Text;
 using Newtonsoft.Json;
 using FlagsmithEngine.Feature.Models;
-using System.Linq;
 
 namespace FlagsmithEngine.Identity.Models
 {
     public class IdentityModel
     {
-        [JsonProperty("identity_uuid")]
-        public string IdentityUUID { get; set; } = Guid.NewGuid().ToString();
         [JsonProperty("identifier")]
         public string Identifier { get; set; }
-        [JsonProperty("environment_api_key")]
-        public string EnvironmentApiKey { get; set; }
-        [JsonProperty("created_date")]
-        public DateTime CreatedDate { get; set; }
-        [JsonProperty("identity_traits")]
-        public List<TraitModel> IdentityTraits { get; set; }
         [JsonProperty("identity_features")]
         public IdentityFeaturesList IdentityFeatures { get; set; }
-        [JsonProperty("django_id")]
-        public int? DjangoId { get; set; }
-        public string CompositeKey => GenerateCompositeKey(EnvironmentApiKey, Identifier);
-
-        public string GenerateCompositeKey(string envKey, string identifier) => $"{envKey}_{identifier}";
-        public void UpdateTraits(List<TraitModel> traits)
-        {
-            var existingModels = IdentityTraits?.Count > 0 ? IdentityTraits.ToDictionary(x => x.TraitKey) : new Dictionary<string, TraitModel>();
-            traits.ForEach(trait =>
-            {
-                if (trait.TraitValue is null)
-                    existingModels.Remove(trait.TraitKey);
-                else
-                    existingModels[trait.TraitKey] = trait;
-            });
-            IdentityTraits = existingModels.Values.ToList();
-        }
     }
 }

Flagsmith.Engine/Response/Response.cs

@@ -1,7 +1,4 @@
-using FlagsmithEngine.Environment.Models;
-using FlagsmithEngine.Identity.Models;
-using FlagsmithEngine.Segment.Models;
-using FlagsmithEngine.Trait.Models;
+using FlagsmithEngine.Segment.Models;
 using FlagsmithEngine.Utils;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
@@ -276,42 +273,6 @@ private static FlagResult<FeatureMetadataT> GetFlagResult<_, FeatureMetadataT>(E
 
     public static class Evaluator
     {
-        public static Hashing Hashing = new Hashing();
-
-        public static bool EvaluateIdentityInSegment(IdentityModel identity, SegmentModel segment, List<TraitModel> overrideTraits)
-        {
-            var traits = overrideTraits?.Any() == true ? overrideTraits : identity.IdentityTraits;
-            var identityHashKey = identity.DjangoId == null ? identity.CompositeKey : identity.DjangoId.ToString();
-            return segment.Rules?.Any() == true && segment.Rules.All(rule => TraitsMatchSegmentRule(traits, rule, segment.Id.ToString(), identityHashKey));
-        }
-
-        static bool TraitsMatchSegmentRule(List<TraitModel> identityTraits, SegmentRuleModel rule, string segmentId, string identityId)
-        {
-            var matchesConditions = !rule.Conditions.Any() || rule.MatchingFunction(rule.Conditions.Select(c =>
-                    TraitsMatchSegmentCondition(identityTraits, c, segmentId, identityId)).ToList()
-            );
-            return matchesConditions && (rule.Rules?.All(r => TraitsMatchSegmentRule(identityTraits, r, segmentId, identityId)) ?? true);
-        }
-
-        static bool TraitsMatchSegmentCondition(List<TraitModel> identityTraits, SegmentConditionModel condition, string segmentId, string identityId)
-        {
-            if (condition.Operator == Constants.PercentageSplit)
-                return Hashing.GetHashedPercentageForObjectIds(new List<string>() { segmentId, identityId }) <= float.Parse(condition.Value);
-
-            var trait = identityTraits?.FirstOrDefault(t => t.TraitKey == condition.Property);
-
-            if (condition.Operator == Constants.IsSet)
-            {
-                return trait != null;
-            }
-            else if (condition.Operator == Constants.IsNotSet)
-            {
-                return trait == null;
-            }
-
-            return trait != null && MatchesTraitValue(trait.TraitValue, condition);
-        }
-
         public static bool MatchesTraitValue(object traitValue, SegmentConditionModel condition)
         {
             var exceptionOperatorMethods = new Dictionary<string, string>()

Flagsmith.Engine/Segment/Evaluator.cs

@@ -1,7 +1,6 @@
-using System;
 using System.Collections.Generic;
-using System.Linq;
 using Newtonsoft.Json;
+
 namespace FlagsmithEngine.Segment.Models
 {
     public class SegmentRuleModel
@@ -12,16 +11,5 @@ public class SegmentRuleModel
         public List<SegmentRuleModel> Rules { get; set; }
         [JsonProperty("conditions")]
         public List<SegmentConditionModel> Conditions { get; set; } = new List<SegmentConditionModel>();
-
-        public bool MatchingFunction(List<bool> list)
-        {
-            switch (Type)
-            {
-                case Constants.AllRule: return list.All(x => x);
-                case Constants.AnyRule: return list.Any(x => x);
-                case Constants.NoneRule: return !list.Any(x => x);
-            }
-            throw new Exception("Rule Not Found");
-        }
     }
 }

Flagsmith.Engine/Segment/Models/SegmentRuleModel.cs

@@ -1,20 +1,7 @@
-using System;
-using System.Collections.Generic;
-using System.Text;
+using System;
 
 namespace FlagsmithEngine.Exceptions
 {
-    public class FeatureStateNotFound : Exception
-    {
-        //Overriding the Message property
-        public override string Message
-        {
-            get
-            {
-                return "Feature State not found.";
-            }
-        }
-    }
     public class DuplicateFeatureState : Exception
     {
     }