even more efficient loop

khvn26 · khvn26 · commit 25ad1b9beccb · 2025-08-12T18:05:46.000+01:00
diff --git a/flag_engine/segments/evaluator.py b/flag_engine/segments/evaluator.py
@@ -100,6 +100,7 @@ def get_evaluation_result(context: EvaluationContext) -> EvaluationResult:
                 ):
                     segment_feature_contexts[feature_key] = override_feature_context
 
+    identity_key = get_context_value(context, "$.identity.key")
     flags: typing.List[FlagResult] = [
         (
             {
@@ -115,8 +116,8 @@ def get_evaluation_result(context: EvaluationContext) -> EvaluationResult:
                 )
             )
             else get_flag_result_from_feature_context(
-                feature_context,
-                get_context_value(context, "$.identity.key"),
+                feature_context=feature_context,
+                key=identity_key,
             )
         )
         for feature_context in (context.get("features") or {}).values()

Original file line number	Diff line number	Diff line change
`@@ -100,6 +100,7 @@ def get_evaluation_result(context: EvaluationContext) -> EvaluationResult:`
`100`	`100`	`):`
`101`	`101`	`segment_feature_contexts[feature_key] = override_feature_context`
`102`	`102`
	`103`	`+ identity_key = get_context_value(context, "$.identity.key")`
`103`	`104`	`flags: typing.List[FlagResult] = [`
`104`	`105`	`(`
`105`	`106`	`{`
`@@ -115,8 +116,8 @@ def get_evaluation_result(context: EvaluationContext) -> EvaluationResult:`
`115`	`116`	`)`
`116`	`117`	`)`
`117`	`118`	`else get_flag_result_from_feature_context(`
`118`		`- feature_context,`
`119`		`- get_context_value(context, "$.identity.key"),`
	`119`	`+ feature_context=feature_context,`
	`120`	`+ key=identity_key,`
`120`	`121`	`)`
`121`	`122`	`)`
`122`	`123`	`for feature_context in (context.get("features") or {}).values()`