fix coverage

Author: khvn26

flag_engine/segments/models.py

@@ -21,10 +21,6 @@ class SegmentRuleModel(BaseModel):
     rules: typing.List["SegmentRuleModel"] = Field(default_factory=list)
     conditions: typing.List[SegmentConditionModel] = Field(default_factory=list)
 
-    @staticmethod
-    def none(iterable: typing.Iterable[object]) -> bool:
-        return not any(iterable)
-
     @property
     def matching_function(self) -> typing.Callable[[typing.Iterable[object]], bool]:
         return get_matching_function(self.type)

flag_engine/segments/utils.py

@@ -9,9 +9,9 @@ def get_matching_function(
     return {
         "ANY": any,
         "ALL": all,
-        "NONE": _none,
+        "NONE": none,
     }[segment_type]
 
 
-def _none(iterable: typing.Iterable[object]) -> bool:
+def none(iterable: typing.Iterable[object]) -> bool:
     return not any(iterable)

tests/unit/segments/test_segments_models.py

@@ -5,36 +5,19 @@
 from flag_engine.segments import constants
 from flag_engine.segments.models import SegmentRuleModel
 from flag_engine.segments.types import RuleType
-from flag_engine.segments.utils import _none
-
-
-@pytest.mark.parametrize(
-    "iterable, expected_result",
-    (
-        ([], True),
-        ([False], True),
-        ([False, False], True),
-        ([False, True], False),
-        ([True, True], False),
-    ),
-)
-def test_segment_rule_none(
-    iterable: typing.List[bool],
-    expected_result: bool,
-) -> None:
-    assert SegmentRuleModel.none(iterable) is expected_result
+from flag_engine.segments.utils import none
 
 
 @pytest.mark.parametrize(
     "rule_type, expected_function",
     (
         (constants.ALL_RULE, all),
         (constants.ANY_RULE, any),
-        (constants.NONE_RULE, _none),
+        (constants.NONE_RULE, none),
     ),
 )
 def test_segment_rule_matching_function(
     rule_type: RuleType,
     expected_function: typing.Callable[[typing.Iterable[object]], bool],
 ) -> None:
-    assert SegmentRuleModel(type=rule_type).matching_function == expected_function
+    assert SegmentRuleModel(type=rule_type).matching_function is expected_function

tests/unit/segments/test_segments_utils.py

@@ -0,0 +1,22 @@
+import typing
+
+import pytest
+
+from flag_engine.segments.utils import none
+
+
+@pytest.mark.parametrize(
+    "iterable, expected_result",
+    (
+        ([], True),
+        ([False], True),
+        ([False, False], True),
+        ([False, True], False),
+        ([True, True], False),
+    ),
+)
+def test_segment_rule_none(
+    iterable: typing.List[bool],
+    expected_result: bool,
+) -> None:
+    assert none(iterable) is expected_result