use segment name for identity overrides

Author: khvn26

flag_engine/context/mappers.py

@@ -112,10 +112,9 @@ def _map_identity_overrides_to_segment_contexts(
         features_to_identifiers[overrides_key].append(identity_override.identifier)
     segment_contexts: typing.Dict[str, SegmentContext] = {}
     for overrides_key, identifiers in features_to_identifiers.items():
-        segment_name = f"overrides_{abs(hash(overrides_key))}"
-        segment_contexts[segment_name] = SegmentContext(
+        segment_contexts[str(hash(overrides_key))] = SegmentContext(
             key="",  # Identity override segments never use % Split operator
-            name=segment_name,
+            name="identity_overrides",
             rules=[
                 {
                     "type": "ALL",

flag_engine/segments/evaluator.py

@@ -49,7 +49,7 @@ def get_identity_segments(
         override_traits=None,
     )
     return [
-        SegmentModel(id=segment_context["key"], name=segment_context["name"])
+        SegmentModel(id=segment_context["key"] or 0, name=segment_context["name"])
         for segment_context in get_evaluation_result(context)["segments"]
     ]
 

tests/unit/segments/test_segments_evaluator.py

@@ -13,6 +13,7 @@
     SegmentContext,
 )
 from flag_engine.environments.models import EnvironmentModel
+from flag_engine.features.models import FeatureModel, FeatureStateModel
 from flag_engine.identities.models import IdentityModel
 from flag_engine.result.types import FlagResult
 from flag_engine.segments import constants
@@ -791,6 +792,51 @@ def test_get_evaluation_result__two_segments_override_same_feature__returns_expe
     }
 
 
+def test_get_evaluation_result__identity_override__returns_expected(
+    environment: EnvironmentModel,
+    feature_1: FeatureModel,
+    identity: IdentityModel,
+) -> None:
+    # Given
+    identity.identity_features.append(
+        FeatureStateModel(
+            feature=feature_1,
+            enabled=True,
+            value="overridden_for_identity",
+        )
+    )
+    context = map_environment_identity_to_context(
+        environment=environment,
+        identity=identity,
+        override_traits=None,
+    )
+
+    # When
+    result = get_evaluation_result(context)
+
+    # Then
+    assert result == {
+        "context": context,
+        "flags": [
+            {
+                "enabled": True,
+                "feature_key": "1",
+                "name": "feature_1",
+                "reason": "TARGETING_MATCH; segment=identity_overrides",
+                "value": None,
+            },
+            {
+                "enabled": False,
+                "feature_key": "2",
+                "name": "feature_2",
+                "reason": "DEFAULT",
+                "value": None,
+            },
+        ],
+        "segments": [{"key": "", "name": "identity_overrides"}],
+    }
+
+
 @pytest.mark.parametrize(
     "percentage_value, expected_result",
     (