Release 2.0.5 (#125)

* Bump version 2.0.5

* Return updated traits when updating (#126)

Author: matthewelwell

flag_engine/identities/models.py

@@ -28,7 +28,7 @@ def composite_key(self) -> str:
     def generate_composite_key(env_key: str, identifier: str) -> str:
         return f"{env_key}_{identifier}"
 
-    def update_traits(self, traits: typing.List[TraitModel]) -> None:
+    def update_traits(self, traits: typing.List[TraitModel]) -> typing.List[TraitModel]:
         existing_traits = {trait.trait_key: trait for trait in self.identity_traits}
 
         for trait in traits:
@@ -38,3 +38,4 @@ def update_traits(self, traits: typing.List[TraitModel]) -> None:
                 existing_traits[trait.trait_key] = trait
 
         self.identity_traits = list(existing_traits.values())
+        return self.identity_traits

setup.py

@@ -2,7 +2,7 @@
 
 setup(
     name="flagsmith-flag-engine",
-    version="2.0.4",
+    version="2.0.5",
     author="Flagsmith",
     author_email="support@flagsmith.com",
     packages=find_packages(include=["flag_engine", "flag_engine.*"]),

tests/unit/identities/test_identities_models.py

@@ -44,10 +44,10 @@ def test_update_traits_remove_traits_with_none_value(identity_in_segment):
     trait_to_remove = TraitModel(trait_key=trait_key, trait_value=None)
 
     # When
-    identity_in_segment.update_traits([trait_to_remove])
+    updated_traits = identity_in_segment.update_traits([trait_to_remove])
 
     # Then
-    assert identity_in_segment.identity_traits == []
+    assert identity_in_segment.identity_traits == updated_traits == []
 
 
 def test_update_identity_traits_updates_trait_value(identity_in_segment):
@@ -57,9 +57,10 @@ def test_update_identity_traits_updates_trait_value(identity_in_segment):
     trait_to_update = TraitModel(trait_key=trait_key, trait_value=trait_value)
 
     # When
-    identity_in_segment.update_traits([trait_to_update])
+    updated_traits = identity_in_segment.update_traits([trait_to_update])
 
     # Then
+    assert updated_traits == identity_in_segment.identity_traits
     assert len(identity_in_segment.identity_traits) == 1
     assert identity_in_segment.identity_traits[0] == trait_to_update
 
@@ -69,9 +70,10 @@ def test_update_traits_adds_new_traits(identity_in_segment):
     new_trait = TraitModel(trait_key="new_key", trait_value="foobar")
 
     # When
-    identity_in_segment.update_traits([new_trait])
+    updated_traits = identity_in_segment.update_traits([new_trait])
 
     # Then
+    assert updated_traits == identity_in_segment.identity_traits
     assert len(identity_in_segment.identity_traits) == 2
     assert new_trait in identity_in_segment.identity_traits