Skip to content

Commit b0ad7d7

Browse files
committed
improve identity override segments docs
1 parent bef6681 commit b0ad7d7

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/main/java/com/flagsmith/mappers/EngineMappers.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ private static Map<String, SegmentContext> mapIdentityOverridesToSegments(
196196
for (FeatureContext featureContext : overridesKey) {
197197
// Copy the feature context for the override
198198
FeatureContext override = new FeatureContext(featureContext)
199-
.withKey(""); // Override the key for identity overrides
199+
.withKey(""); // Identity overrides are never multivariate, so no need to set key
200200
overrides.add(override);
201201
}
202202

@@ -289,6 +289,9 @@ private static String getFeatureStateKey(JsonNode featureState) {
289289
if (node != null && !node.isNull()) {
290290
return node.asText();
291291
}
292+
// Feature state key is used in multivariate feature evaluation, not to
293+
// identify features uniquely, so if both fields are missing,
294+
// we don't need to care about collisions.
292295
return "";
293296
}
294297

0 commit comments

Comments
 (0)