Skip to content

Commit 935a0ce

Browse files
authored
Merge pull request #133 from Flagsmith/chores/replace_inline_event_trigger
Use un-minified event-trigger, tidy TypeScript
2 parents 4123df0 + de80e7f commit 935a0ce

33 files changed

+170
-39
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,3 +39,4 @@ buck-out/
3939
\.buckd/
4040
android/app/libs
4141
android/keystores/debug.keystore
42+
*.js.map

examples/nextjs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"lint": "next lint"
1010
},
1111
"dependencies": {
12-
"flagsmith-es": "3.4.0",
12+
"flagsmith-es": "3.6.0",
1313
"lodash-es": "^4.17.21",
1414
"next": "12.1.0",
1515
"next-transpile-modules": "^9.0.0",

flagsmith-core.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,6 @@ const Flagsmith = class {
133133
this.getJSON(api + 'identities/?identifier=' + encodeURIComponent(identity)),
134134
])
135135
.then((res) => {
136-
// @ts-ignore
137136
this.withTraits = false
138137
handleResponse(res[0])
139138
if (resolve && !resolved) {
@@ -148,8 +147,7 @@ const Flagsmith = class {
148147
this.getJSON(api + "flags/")
149148
])
150149
.then((res) => {
151-
// @ts-ignore
152-
handleResponse({ flags: res[0] })
150+
handleResponse({ flags: res[0], traits:null })
153151
if (resolve && !resolved) {
154152
resolved = true;
155153
resolve();
@@ -281,11 +279,11 @@ const Flagsmith = class {
281279
}
282280

283281
if (enableDynatrace) {
284-
// @ts-ignore
282+
// @ts-expect-error Dynatrace's dtrum is exposed to global scope
285283
if (typeof dtrum === 'undefined') {
286284
console.error("You have attempted to enable dynatrace but dtrum is undefined, please check you have the Dynatrace RUM JavaScript API installed.")
287285
} else {
288-
// @ts-ignore
286+
// @ts-expect-error Dynatrace's dtrum is exposed to global scope
289287
this.dtrum = dtrum;
290288
}
291289
}

flagsmith-es/index.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

flagsmith-es/index.js.map

Lines changed: 0 additions & 1 deletion
This file was deleted.

flagsmith-es/isomorphic.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

flagsmith-es/isomorphic.js.map

Lines changed: 0 additions & 1 deletion
This file was deleted.

flagsmith-es/next.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

flagsmith-es/next.js.map

Lines changed: 0 additions & 1 deletion
This file was deleted.

flagsmith-es/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "flagsmith-es",
3-
"version": "3.5.0",
3+
"version": "3.6.0",
44
"description": "Feature flagging to support continuous development. This is an esm equivalent of the standard flagsmith npm module.",
55
"main": "./index.js",
66
"type": "module",

0 commit comments

Comments
 (0)