Skip to content

Commit dd15f09

Browse files
committed
Minor: Only trigger onChange if it's defined
1 parent 7815747 commit dd15f09

File tree

10 files changed

+25
-16
lines changed

10 files changed

+25
-16
lines changed

flagsmith-core.ts

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,10 @@ const Flagsmith = class {
8585
this.flags = flags;
8686
this.traits = userTraits;
8787
this.updateStorage();
88+
if(this.trigger) {
89+
this.trigger()
90+
}
8891
if (onChange) {
89-
if(this.trigger) {
90-
this.trigger()
91-
}
9292
onChange(this.oldFlags, {
9393
isFromServer: true,
9494
flagsChanged: !flagsEqual,
@@ -273,10 +273,10 @@ const Flagsmith = class {
273273
}
274274

275275
if (this.flags) { // retrieved flags from local storage
276+
if(this.trigger) {
277+
this.trigger()
278+
}
276279
if (this.onChange) {
277-
if(this.trigger) {
278-
this.trigger()
279-
}
280280
this.onChange(null, { isFromServer: false });
281281
}
282282
this.oldFlags = this.flags;
@@ -302,7 +302,9 @@ const Flagsmith = class {
302302
if(this.trigger) {
303303
this.trigger()
304304
}
305-
this.onChange(null, { isFromServer: false });
305+
if (this.onChange) {
306+
this.onChange(null, { isFromServer: false });
307+
}
306308
}
307309
resolve(true);
308310
}
@@ -315,7 +317,9 @@ const Flagsmith = class {
315317
if(this.trigger) {
316318
this.trigger()
317319
}
318-
this.onChange(null, { isFromServer: false });
320+
if (this.onChange) {
321+
this.onChange(null, { isFromServer: false });
322+
}
319323
}
320324
resolve(true);
321325
}

flagsmith/index.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

flagsmith/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

flagsmith/isomorphic.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

flagsmith/isomorphic.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

flagsmith/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "flagsmith",
3-
"version": "2.0.4",
3+
"version": "2.0.5",
44
"description": "Feature flagging to support continuous development",
55
"main": "./index.js",
66
"repository": {

react-native-flagsmith/index.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

react-native-flagsmith/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

react-native-flagsmith/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-native-flagsmith",
3-
"version": "2.0.4",
3+
"version": "2.0.5",
44
"description": "Feature flagging to support continuous development",
55
"main": "./index.js",
66
"repository": {

types.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,11 @@ export interface IFlagsmith {
132132
*/
133133
identity?:string
134134

135+
/**
136+
* Whether the flagsmith SDK is initialised
137+
*/
138+
initialised?:boolean
139+
135140
/**
136141
* Used internally, this function will callback separately to onChange whenever flags are updated
137142
*/

0 commit comments

Comments
 (0)