fail if using local eval without a server-side key

Author: rolodato

sdk/index.ts

@@ -142,9 +142,7 @@ export class Flagsmith {
 
             if (this.enableLocalEvaluation) {
                 if (!this.environmentKey.startsWith('ser.')) {
-                    console.error(
-                        'In order to use local evaluation, please generate a server key in the environment settings page.'
-                    );
+                    throw new Error('Using local evaluation requires a server-side environment key');
                 }
                 if (this.environmentRefreshIntervalSeconds > 0){
                     this.environmentDataPollingManager = new EnvironmentDataPollingManager(

tests/sdk/flagsmith-cache.test.ts

@@ -61,7 +61,7 @@ test('test_get_environment_flags_uses_local_environment_when_available', async (
   const cache = new TestCache();
   const set = vi.spyOn(cache, 'set');
 
-  const flg = flagsmith({ cache, enableLocalEvaluation: true });
+  const flg = flagsmith({ cache, environmentKey: 'ser.key', enableLocalEvaluation: true });
   const model = environmentModel(JSON.parse(environmentJSON));
   const getEnvironment = vi.spyOn(flg, 'getEnvironment')
   getEnvironment.mockResolvedValue(model)

tests/sdk/flagsmith.test.ts

@@ -31,12 +31,12 @@ test('test_flagsmith_starts_polling_manager_on_init_if_enabled', () => {
 
 test('test_flagsmith_local_evaluation_key_required', () => {
     fetch.mockResolvedValue(new Response(environmentJSON));
-    console.error = vi.fn();
-    new Flagsmith({
-        environmentKey: 'bad.key',
-        enableLocalEvaluation: true
-    });
-    expect(console.error).toBeCalled();
+    expect(() => {
+        new Flagsmith({
+            environmentKey: 'bad.key',
+            enableLocalEvaluation: true
+        });
+    }).toThrow('Using local evaluation requires a server-side environment key')
 });
 
 test('test_update_environment_sets_environment', async () => {