Skip to content

Commit 798995f

Browse files
committed
feat: boolean-trait-returns-false-in-operator
1 parent 25dd97c commit 798995f

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

.gitmodules

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
[submodule "tests/engine/engine-tests/engine-test-data"]
22
path = tests/engine/engine-tests/engine-test-data
33
url = [email protected]:Flagsmith/engine-test-data.git
4-
branch = feat/remove-feature-key-fields
4+
branch = v3.0.0

flagsmith-engine/segments/models.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,9 @@ export class SegmentConditionModel {
144144
return parsedTraitValue % divisor === remainder;
145145
},
146146
evaluateIn: (traitValue: string[] | string) => {
147+
if (!traitValue || typeof traitValue === 'boolean') {
148+
return false;
149+
}
147150
if (Array.isArray(this.value)) {
148151
return this.value.includes(traitValue.toString());
149152
}

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@
5858
"deploy": "npm i && npm run build && npm publish",
5959
"deploy:beta": "npm i && npm run build && npm publish --tag beta",
6060
"prepare": "husky install",
61-
"generate-evaluation-result-types": "curl -o evaluation-result.json https://raw.githubusercontent.com/Flagsmith/flagsmith/chore%2Fevaluation-context0key/sdk/evaluation-result.json && npx json2ts -i evaluation-result.json -o flagsmith-engine/evaluation/evaluationResult/evaluationResult.types.ts && rm evaluation-result.json",
62-
"generate-evaluation-context-types": "curl -o evaluation-context.json https://raw.githubusercontent.com/Flagsmith/flagsmith/chore%2Fevaluation-context0key/sdk/evaluation-context.json && npx json2ts -i evaluation-context.json -o flagsmith-engine/evaluation/evaluationContext/evaluationContext.types.ts && rm evaluation-context.json",
61+
"generate-evaluation-result-types": "curl -o evaluation-result.json https://raw.githubusercontent.com/Flagsmith/flagsmith/main/sdk/evaluation-result.json && npx json2ts -i evaluation-result.json -o flagsmith-engine/evaluation/evaluationResult/evaluationResult.types.ts && rm evaluation-result.json",
62+
"generate-evaluation-context-types": "curl -o evaluation-context.json https://raw.githubusercontent.com/Flagsmith/flagsmith/main/sdk/evaluation-context.json && npx json2ts -i evaluation-context.json -o flagsmith-engine/evaluation/evaluationContext/evaluationContext.types.ts && rm evaluation-context.json",
6363
"generate-engine-types": "npm run generate-evaluation-result-types && npm run generate-evaluation-context-types"
6464
},
6565
"dependencies": {

0 commit comments

Comments
 (0)