chore: camel-cased-flagsmith-id

Zaimwa9 · Zaimwa9 · commit c144f7ab8f2b · 2025-10-24T11:24:59.000+02:00
diff --git a/flagsmith-engine/evaluation/evaluationContext/mappers.ts b/flagsmith-engine/evaluation/evaluationContext/mappers.ts
@@ -59,7 +59,7 @@ function mapEnvironmentModelToEvaluationContext(
             variants,
             priority: fs.featureSegment?.priority,
             metadata: {
-                flagsmith_id: fs.feature.id
+                flagsmithId: fs.feature.id
             }
         };
     }
@@ -79,13 +79,13 @@ function mapEnvironmentModelToEvaluationContext(
                           value: fs.getValue(),
                           priority: fs.featureSegment?.priority,
                           metadata: {
-                              flagsmith_id: fs.feature.id
+                              flagsmithId: fs.feature.id
                           }
                       }))
                     : [],
             metadata: {
                 source: SegmentSource.API,
-                flagsmith_id: segment.id
+                flagsmithId: segment.id
             }
         };
     }
@@ -153,7 +153,7 @@ function mapIdentityOverridesToSegments(identityOverrides: IdentityModel[]): Seg
             value: fs.getValue(),
             priority: -Infinity,
             metadata: {
-                flagsmith_id: fs.feature.id
+                flagsmithId: fs.feature.id
             }
         }));
 
diff --git a/flagsmith-engine/evaluation/models.ts b/flagsmith-engine/evaluation/models.ts
@@ -25,7 +25,7 @@ export enum SegmentSource {
 
 // Feature types
 export interface CustomFeatureMetadata extends FeatureMetadata {
-    flagsmith_id: number;
+    flagsmithId: number;
 }
 
 export interface FeatureContextWithMetadata<T extends FeatureMetadata = FeatureMetadata>
@@ -49,7 +49,7 @@ export type EvaluationResultFlags<T extends FeatureMetadata = FeatureMetadata> =
 
 // Segment types
 export interface CustomSegmentMetadata extends SegmentMetadata {
-    flagsmith_id: number;
+    flagsmithId: number;
     source?: SegmentSource;
 }
 
diff --git a/flagsmith-engine/segments/models.ts b/flagsmith-engine/segments/models.ts
@@ -224,7 +224,7 @@ export class SegmentModel {
             if (segmentResult.metadata?.source === SegmentSource.IDENTITY_OVERRIDE) {
                 continue;
             }
-            const flagsmithId = segmentResult.metadata?.flagsmith_id;
+            const flagsmithId = segmentResult.metadata?.flagsmithId;
             if (!flagsmithId) {
                 continue;
             }
@@ -246,11 +246,11 @@ export class SegmentModel {
         if (!overrides) return [];
         return overrides
             .filter(override => {
-                const flagsmithId = override?.metadata?.flagsmith_id;
+                const flagsmithId = override?.metadata?.flagsmithId;
                 return typeof flagsmithId === 'number';
             })
             .map(override => {
-                const flagsmithId = override.metadata!.flagsmith_id as number;
+                const flagsmithId = override.metadata!.flagsmithId as number;
                 const feature = new FeatureModel(
                     flagsmithId,
                     override.name,
diff --git a/sdk/models.ts b/sdk/models.ts
@@ -118,15 +118,15 @@ export class Flags {
     ): Flags {
         const flags: { [key: string]: Flag } = {};
         for (const flag of Object.values(evaluationResult.flags)) {
-            const flagsmith_id = flag.metadata?.flagsmith_id;
-            if (!flagsmith_id) {
+            const flagsmithId = flag.metadata?.flagsmithId;
+            if (!flagsmithId) {
                 continue;
             }
 
             flags[flag.name] = new Flag({
                 enabled: flag.enabled,
                 value: flag.value ?? null,
-                featureId: flagsmith_id,
+                featureId: flagsmithId,
                 featureName: flag.name,
                 reason: flag.reason
             });
diff --git a/tests/engine/unit/engine.test.ts b/tests/engine/unit/engine.test.ts
@@ -115,7 +115,7 @@ test('shouldApplyOverride with priority conflicts', () => {
                 enabled: true,
                 value: 'value',
                 priority: 5,
-                metadata: { flagsmith_id: 1 }
+                metadata: { flagsmithId: 1 }
             },
             segmentName: 'segment1'
         }
@@ -185,7 +185,7 @@ test('evaluateSegments handles segments with identity identifier matching', () =
                 name: 'feature1',
                 enabled: false,
                 value: 'default_value',
-                metadata: { flagsmith_id: 1 }
+                metadata: { flagsmithId: 1 }
             }
         }
     };
@@ -272,7 +272,7 @@ test('evaluateSegments handles priority conflicts correctly', () => {
                 name: 'feature1',
                 enabled: false,
                 value: 'default_value',
-                metadata: { flagsmith_id: 1 }
+                metadata: { flagsmithId: 1 }
             }
         }
     };
@@ -343,7 +343,7 @@ test('evaluateFeatures with multivariate evaluation', () => {
                     { value: 'variant_a', weight: 0, priority: 1 },
                     { value: 'variant_b', weight: 100, priority: 2 }
                 ],
-                metadata: { flagsmith_id: 1 }
+                metadata: { flagsmithId: 1 }
             }
         },
         identity: { key: 'test_user', identifier: 'test_user' },
diff --git a/tests/engine/unit/segments/segments_model.test.ts b/tests/engine/unit/segments/segments_model.test.ts
@@ -141,7 +141,7 @@ test('test_segment_rule_matching_function', () => {
 });
 
 test('test_fromSegmentResult_with_multiple_variants', () => {
-    const segmentResults = [{ name: 'test_segment', metadata: { flagsmith_id: '1' } }];
+    const segmentResults = [{ name: 'test_segment', metadata: { flagsmithId: '1' } }];
 
     const evaluationContext: EvaluationContext = {
         identity: {
@@ -159,7 +159,7 @@ test('test_fromSegmentResult_with_multiple_variants', () => {
                 name: 'test_segment',
                 metadata: {
                     source: SegmentSource.API,
-                    flagsmith_id: '1'
+                    flagsmithId: '1'
                 },
                 rules: [
                     {
@@ -181,7 +181,7 @@ test('test_fromSegmentResult_with_multiple_variants', () => {
                         value: 'default_value',
                         priority: 1,
                         metadata: {
-                            flagsmith_id: 1
+                            flagsmithId: 1
                         },
                         variants: [
                             { id: 1, value: 'variant_a', weight: 30 },

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ function mapEnvironmentModelToEvaluationContext(`
`59`	`59`	`variants,`
`60`	`60`	`priority: fs.featureSegment?.priority,`
`61`	`61`	`metadata: {`
`62`		`- flagsmith_id: fs.feature.id`
	`62`	`+ flagsmithId: fs.feature.id`
`63`	`63`	`}`
`64`	`64`	`};`
`65`	`65`	`}`
`@@ -79,13 +79,13 @@ function mapEnvironmentModelToEvaluationContext(`
`79`	`79`	`value: fs.getValue(),`
`80`	`80`	`priority: fs.featureSegment?.priority,`
`81`	`81`	`metadata: {`
`82`		`- flagsmith_id: fs.feature.id`
	`82`	`+ flagsmithId: fs.feature.id`
`83`	`83`	`}`
`84`	`84`	`}))`
`85`	`85`	`: [],`
`86`	`86`	`metadata: {`
`87`	`87`	`source: SegmentSource.API,`
`88`		`- flagsmith_id: segment.id`
	`88`	`+ flagsmithId: segment.id`
`89`	`89`	`}`
`90`	`90`	`};`
`91`	`91`	`}`
`@@ -153,7 +153,7 @@ function mapIdentityOverridesToSegments(identityOverrides: IdentityModel[]): Seg`
`153`	`153`	`value: fs.getValue(),`
`154`	`154`	`priority: -Infinity,`
`155`	`155`	`metadata: {`
`156`		`- flagsmith_id: fs.feature.id`
	`156`	`+ flagsmithId: fs.feature.id`
`157`	`157`	`}`
`158`	`158`	`}));`
`159`	`159`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ export enum SegmentSource {`
`25`	`25`
`26`	`26`	`// Feature types`
`27`	`27`	`export interface CustomFeatureMetadata extends FeatureMetadata {`
`28`		`- flagsmith_id: number;`
	`28`	`+ flagsmithId: number;`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`export interface FeatureContextWithMetadata<T extends FeatureMetadata = FeatureMetadata>`
`@@ -49,7 +49,7 @@ export type EvaluationResultFlags<T extends FeatureMetadata = FeatureMetadata> =`
`49`	`49`
`50`	`50`	`// Segment types`
`51`	`51`	`export interface CustomSegmentMetadata extends SegmentMetadata {`
`52`		`- flagsmith_id: number;`
	`52`	`+ flagsmithId: number;`
`53`	`53`	`source?: SegmentSource;`
`54`	`54`	`}`
`55`	`55`
Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ test('shouldApplyOverride with priority conflicts', () => {`
`115`	`115`	`enabled: true,`
`116`	`116`	`value: 'value',`
`117`	`117`	`priority: 5,`
`118`		`- metadata: { flagsmith_id: 1 }`
	`118`	`+ metadata: { flagsmithId: 1 }`
`119`	`119`	`},`
`120`	`120`	`segmentName: 'segment1'`
`121`	`121`	`}`
`@@ -185,7 +185,7 @@ test('evaluateSegments handles segments with identity identifier matching', () =`
`185`	`185`	`name: 'feature1',`
`186`	`186`	`enabled: false,`
`187`	`187`	`value: 'default_value',`
`188`		`- metadata: { flagsmith_id: 1 }`
	`188`	`+ metadata: { flagsmithId: 1 }`
`189`	`189`	`}`
`190`	`190`	`}`
`191`	`191`	`};`
`@@ -272,7 +272,7 @@ test('evaluateSegments handles priority conflicts correctly', () => {`
`272`	`272`	`name: 'feature1',`
`273`	`273`	`enabled: false,`
`274`	`274`	`value: 'default_value',`
`275`		`- metadata: { flagsmith_id: 1 }`
	`275`	`+ metadata: { flagsmithId: 1 }`
`276`	`276`	`}`
`277`	`277`	`}`
`278`	`278`	`};`
`@@ -343,7 +343,7 @@ test('evaluateFeatures with multivariate evaluation', () => {`
`343`	`343`	`{ value: 'variant_a', weight: 0, priority: 1 },`
`344`	`344`	`{ value: 'variant_b', weight: 100, priority: 2 }`
`345`	`345`	`],`
`346`		`- metadata: { flagsmith_id: 1 }`
	`346`	`+ metadata: { flagsmithId: 1 }`
`347`	`347`	`}`
`348`	`348`	`},`
`349`	`349`	`identity: { key: 'test_user', identifier: 'test_user' },`