Skip to content

Commit 0f08fb1

Browse files
committed
feat: implemented-should-apply-override
1 parent a2fd5a8 commit 0f08fb1

File tree

1 file changed

+4
-3
lines changed
  • lib/flagsmith/engine/evaluation

1 file changed

+4
-3
lines changed

lib/flagsmith/engine/evaluation/core.rb

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ def process_segment_overrides(identity_segments)
5656

5757
overrides_list.each do |override|
5858
if should_apply_override(override, segment_overrides)
59-
segment_overrides[override[:feature_key]] = {
59+
segment_overrides[override[:name]] = {
6060
feature: override,
6161
segment_name: segment[:name]
6262
}
@@ -83,8 +83,9 @@ def get_multivariate_feature_value(_feature, _identity_key)
8383
end
8484

8585
# returns boolean
86-
def should_apply_override(_override, _existing_overrides)
87-
raise NotImplementedError
86+
def should_apply_override(override, existing_overrides)
87+
current_override = existing_overrides[override[:name]]
88+
!current_override || higher_priority?(override[:priority], current_override[:feature][:priority])
8889
end
8990

9091
private

0 commit comments

Comments
 (0)