Remove method and replace with simple logic

Author: zachaysan

lib/flagsmith.rb

@@ -217,8 +217,16 @@ def environment_flags_from_api
           environment_flags_from_document
         end
       else
-        rescue_with_default_handler do
-          return process_environment_flags_from_api
+        begin
+          process_environment_flags_from_api
+        rescue StandardError
+          if default_flag_handler
+            return Flagsmith::Flags::Collection.new(
+              {},
+              default_flag_handler: default_flag_handler
+            )
+          end
+          raise
         end
       end
     end
@@ -244,8 +252,16 @@ def get_identity_flags_from_api(identifier, traits = {})
           get_identity_flags_from_document(identifier, traits)
         end
       else
-        rescue_with_default_handler do
-          return process_identity_flags_from_api(identifier, traits)
+        begin
+          process_identity_flags_from_api(identifier, traits)
+        rescue StandardError
+          if default_flag_handler
+            return Flagsmith::Flags::Collection.new(
+              {},
+              default_flag_handler: default_flag_handler
+            )
+          end
+          raise
         end
       end
     end
@@ -263,18 +279,6 @@ def process_identity_flags_from_api(identifier, traits = {})
       )
     end
 
-    def rescue_with_default_handler
-      yield
-    rescue StandardError
-      if default_flag_handler
-        return Flagsmith::Flags::Collection.new(
-          {},
-          default_flag_handler: default_flag_handler
-        )
-      end
-      raise
-    end
-
     def build_identity_model(identifier, traits = {})
       unless environment
         raise Flagsmith::ClientError,