Skip to content

Commit 7c15dd5

Browse files
committed
Merge branch 'feat/evaluation-context-mappers' of github.com:Flagsmith/flagsmith-ruby-client into feat/evaluation-get-result
2 parents 3b729fc + 6c8dc0b commit 7c15dd5

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

lib/flagsmith/engine/environments/models.rb

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,14 @@ module Flagsmith
44
module Engine
55
# EnvironmentModel
66
class Environment
7-
attr_reader :id, :api_key
7+
attr_reader :id, :api_key, :name
88
attr_accessor :project, :feature_states, :amplitude_config, :segment_config,
99
:mixpanel_config, :heap_config, :identity_overrides
1010

11-
def initialize(id:, api_key:, project:, feature_states: [], identity_overrides: [])
11+
def initialize(id:, api_key:, name: nil, project:, feature_states: [], identity_overrides: [])
1212
@id = id
1313
@api_key = api_key
14+
@name = name
1415
@project = project
1516
@feature_states = feature_states
1617
@identity_overrides = identity_overrides
@@ -28,7 +29,7 @@ def build(json)
2829
Flagsmith::Engine::Identity.build(io)
2930
end
3031

31-
new(**json.slice(:id, :api_key).merge(
32+
new(**json.slice(:id, :api_key, :name).merge(
3233
project: project,
3334
feature_states: feature_states,
3435
identity_overrides: identity_overrides

lib/flagsmith/engine/evaluation/mappers/environment.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ module Environment
99
def self.build_environment_context(environment)
1010
{
1111
key: environment.api_key,
12-
name: environment.project.name
12+
name: environment.name
1313
}
1414
end
1515

spec/engine/unit/evaluation_context_mappers_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
# Then - verify structure
2121
expect(context).to be_a(Hash)
2222
expect(context[:environment][:key]).to eq('B62qaMZNwfiqT76p38ggrQ')
23-
expect(context[:environment][:name]).to eq('Test project')
23+
expect(context[:environment][:name]).to eq('Test environment')
2424
expect(context[:identity]).to be_nil
2525

2626
# Verify segments

spec/sdk/fixtures/environment.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"api_key": "B62qaMZNwfiqT76p38ggrQ",
3+
"name": "Test environment",
34
"project": {
45
"name": "Test project",
56
"organisation": {

0 commit comments

Comments
 (0)