Use feature name instead of id for analytics (#17)

Author: matthewelwell

lib/flagsmith/sdk/analytics_processor.rb

@@ -31,8 +31,8 @@ def flush
       @last_flushed = Time.now
     end
 
-    def track_feature(feature_id)
-      @analytics_data[feature_id] = @analytics_data.fetch(feature_id, 0) + 1
+    def track_feature(feature_name)
+      @analytics_data[feature_name] = @analytics_data.fetch(feature_name, 0) + 1
       flush if (Time.now - @last_flushed) > TIMER * 1000
     end
   end

lib/flagsmith/sdk/models/flags.rb

@@ -122,7 +122,7 @@ def feature_value(feature_name)
       def get_flag(feature_name)
         key = Flagsmith::Flags::Collection.normalize_key(feature_name)
         flag = flags.fetch(key)
-        @analytics_processor.track_feature(flag.feature_id) if @analytics_processor && flag.feature_id
+        @analytics_processor.track_feature(flag.feature_name) if @analytics_processor && flag.feature_id
         flag
       rescue KeyError
         return @default_flag_handler.call(feature_name) if @default_flag_handler

spec/sdk/analytics_processor_spec.rb

@@ -19,25 +19,25 @@
   end
 
   it 'test_analytics_processor_track_feature_updates_analytics_data' do
-    subject.track_feature(1)
-    expect(subject.analytics_data[1]).to eq(1)
+    subject.track_feature("my_feature")
+    expect(subject.analytics_data["my_feature"]).to eq(1)
 
-    subject.track_feature(1)
-    expect(subject.analytics_data[1]).to eq(2)
+    subject.track_feature("my_feature")
+    expect(subject.analytics_data["my_feature"]).to eq(2)
   end
 
   it 'test_analytics_processor_flush_clears_analytics_data' do
-    subject.track_feature(1)
+    subject.track_feature("my_feature")
     subject.flush
     expect(subject.analytics_data).to eql({})
   end
 
   it 'test_analytics_processor_flush_post_request_data_match_ananlytics_data' do
-    subject.track_feature(1)
-    subject.track_feature(2)
+    subject.track_feature("my_feature_1")
+    subject.track_feature("my_feature_2")
     expect(flagsmith.api_client).to receive(:post).exactly(1).times do |uri_path, body|
       expect(uri_path).to eq('analytics/flags/')
-      expect(body).to eq({ 1 => 1, 2 => 1 }.to_json)
+      expect(body).to eq({ "my_feature_1" => 1, "my_feature_2" => 1 }.to_json)
     end
     subject.flush
   end