Skip to content

Commit 9ddffec

Browse files
committed
Merge branch 'feat/evaluation-get-result' of github.com:Flagsmith/flagsmith-ruby-client into feat/sdk-consumes-context-engine
2 parents aafd27d + 2f3850c commit 9ddffec

File tree

4 files changed

+2
-8
lines changed

4 files changed

+2
-8
lines changed

lib/flagsmith/engine/mappers/environment.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,9 @@ def self.build_features_context(feature_states)
2020
features
2121
end
2222

23-
def self.build_feature_hash(feature_state) # rubocop:disable Metrics/MethodLength
23+
def self.build_feature_hash(feature_state)
2424
feature_hash = {
2525
key: feature_state.django_id&.to_s || feature_state.uuid,
26-
feature_key: feature_state.feature.id.to_s,
2726
name: feature_state.feature.name,
2827
enabled: feature_state.enabled,
2928
value: feature_state.get_value,

lib/flagsmith/engine/mappers/identity.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,10 @@ def self.group_by_overrides(identity_overrides)
4444
features_to_identifiers
4545
end
4646

47-
def self.build_overrides_key(identity_features) # rubocop:disable Metrics/MethodLength
47+
def self.build_overrides_key(identity_features)
4848
sorted_features = identity_features.to_a.sort_by { |fs| fs.feature.name }
4949
sorted_features.map do |feature_state|
5050
{
51-
feature_key: feature_state.feature.id.to_s,
5251
name: feature_state.feature.name,
5352
enabled: feature_state.enabled,
5453
value: feature_state.get_value,

lib/flagsmith/engine/mappers/segments.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ def self.build_overrides(feature_states) # rubocop:disable Metrics/MethodLength
3030
feature_states.map do |feature_state|
3131
override_hash = {
3232
key: feature_state.django_id&.to_s || feature_state.uuid,
33-
feature_key: feature_state.feature.id.to_s,
3433
name: feature_state.feature.name,
3534
enabled: feature_state.enabled,
3635
value: feature_state.get_value,

spec/engine/unit/evaluation_context_mappers_spec.rb

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@
6868
expect(override_condition[:value]).to include('overridden-id')
6969

7070
override = identity_override_segment[:overrides][0]
71-
expect(override[:feature_key]).to eq('1')
7271
expect(override[:name]).to eq('some_feature')
7372
expect(override[:enabled]).to be false
7473
expect(override[:value]).to eq('some-overridden-value')
@@ -80,7 +79,6 @@
8079
expect(context[:features]).to have_key('some_feature')
8180

8281
some_feature = context[:features]['some_feature']
83-
expect(some_feature[:feature_key]).to eq('1')
8482
expect(some_feature[:name]).to eq('some_feature')
8583
expect(some_feature[:enabled]).to be true
8684
expect(some_feature[:value]).to eq('some-value')
@@ -90,7 +88,6 @@
9088
# Verify multivariate feature
9189
expect(context[:features]).to have_key('test_mv')
9290
test_mv = context[:features]['test_mv']
93-
expect(test_mv[:feature_key]).to eq('83755')
9491
expect(test_mv[:name]).to eq('test_mv')
9592
expect(test_mv[:enabled]).to be false
9693
expect(test_mv[:value]).to eq('1111')

0 commit comments

Comments
 (0)