feat: linter

Author: Zaimwa9

lib/flagsmith/engine/evaluation/core.rb

@@ -34,13 +34,7 @@ def evaluate_segments(evaluation_context)
           identity_segments = get_segments_from_context(evaluation_context)
 
           segments = identity_segments.map do |segment|
-            result = {
-              name: segment[:name]
-            }
-
-            result[:metadata] = segment[:metadata] if segment[:metadata]
-
-            result
+            { name: segment[:name], metadata: segment[:metadata] }.compact
           end
 
           segment_overrides = process_segment_overrides(identity_segments)
@@ -131,7 +125,7 @@ def get_multivariate_feature_value(feature, identity_key)
         # returns boolean
         def should_apply_override(override, existing_overrides)
           current_override = existing_overrides[override[:name]]
-          !current_override || is_stronger_priority?(override[:priority], current_override[:feature][:priority])
+          !current_override || stronger_priority?(override[:priority], current_override[:feature][:priority])
         end
 
         private
@@ -148,7 +142,7 @@ def get_identity_key(evaluation_context)
         end
 
         # returns boolean
-        def is_stronger_priority?(priority_a, priority_b)
+        def stronger_priority?(priority_a, priority_b)
           (priority_a || WEAKEST_PRIORITY) < (priority_b || WEAKEST_PRIORITY)
         end
       end

lib/flagsmith/engine/segments/evaluator.rb

@@ -196,7 +196,7 @@ def evaluate_rule_conditions(rule_type, condition_results)
         def get_trait_value(property, context)
           if property.start_with?('$.')
             context_value = get_context_value(property, context)
-            return context_value if !context_value.nil? && is_primitive?(context_value)
+            return context_value if !context_value.nil? && primitive?(context_value)
           end
 
           traits = context.dig(:identity, :traits) || {}
@@ -232,7 +232,7 @@ def get_identity_key_from_context(context)
         #
         # @param value [Object] The value to check
         # @return [Boolean] True if value is primitive (not an object or array)
-        def is_primitive?(value)
+        def primitive?(value)
           return true if value.nil?
 
           !(value.is_a?(Hash) || value.is_a?(Array))

lib/flagsmith/engine/segments/models.rb

@@ -54,7 +54,7 @@ def initialize(operator:, value:, property: nil)
           @property = property
         end
 
-        def match_trait_value?(trait_value)
+        def match_trait_value?(trait_value) # rubocop:disable Metrics/MethodLength
           if @value.is_a?(String) && @value.match?(/:semver$/)
             begin
               trait_value = Semantic::Version.new(trait_value.to_s.gsub(/:semver$/, ''))
@@ -73,8 +73,7 @@ def match_trait_value?(trait_value)
           MATCHING_FUNCTIONS[operator]&.call(trait_value, formatted_value)
         end
 
-        # rubocop:disable Metrics/AbcSize
-        def format_to_type_of(input)
+        def format_to_type_of(input) # rubocop:disable Metrics/AbcSize
           {
             'String' => ->(v) { v.to_s },
             'Semantic::Version' => ->(v) { Semantic::Version.new(v.to_s.gsub(/:semver$/, '')) },
@@ -91,7 +90,6 @@ def format_to_type_of(input)
             }
           }[input.class.to_s]
         end
-        # rubocop:enable Metrics/AbcSize
 
         def match_modulo_value(trait_value)
           divisor, remainder = @value.split('|')
@@ -100,10 +98,8 @@ def match_modulo_value(trait_value)
           false
         end
 
-        def match_in_value(trait_value)
-          return false if trait_value.nil? || trait_value.is_a?(TrueClass) || trait_value.is_a?(FalseClass)
-
-          return false if [true, false].include? trait_value
+        def match_in_value(trait_value) # rubocop:disable Metrics/AbcSize
+          return false if trait_value.nil? || trait_value.is_a?(TrueClass) || trait_value.is_a?(FalseClass) || ([true, false].include? trait_value)
 
           return @value.include?(trait_value.to_s) if @value.is_a?(Array)
 
@@ -114,7 +110,6 @@ def match_in_value(trait_value)
             rescue JSON::ParserError
             end
           end
-
           @value.to_s.split(',').include?(trait_value.to_s)
         end