Skip to content

Commit 560a04d

Browse files
fix: segment change request warning shows on all segments (#6255)
1 parent c4b5a4a commit 560a04d

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

frontend/common/types/requests.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,7 @@ export type Req = {
655655
}
656656
getProjectChangeRequests: PagedRequest<{
657657
project_id: string
658-
version_of?: string
658+
segment_id?: string
659659
live_from_after?: string
660660
committed?: boolean
661661
}>

frontend/web/components/ExistingProjectChangeRequestAlert.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const ExistingProjectChangeRequestAlert: FC<
1414
const { data } = useGetProjectChangeRequestsQuery({
1515
committed: false,
1616
project_id: projectId,
17-
version_of: segmentId,
17+
segment_id: segmentId,
1818
})
1919

2020
if (data?.results?.length) {

frontend/web/components/modals/CreateSegment.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -482,11 +482,11 @@ const CreateSegment: FC<CreateSegmentType> = ({
482482

483483
return (
484484
<>
485-
<ExistingProjectChangeRequestAlert
485+
{segment.id && <ExistingProjectChangeRequestAlert
486486
className='m-2'
487487
projectId={`${projectId}`}
488488
segmentId={`${segment.id}`}
489-
/>
489+
/>}
490490
{isEdit && !condensed ? (
491491
<Tabs value={tab} onChange={(tab: UserTabs) => setTab(tab)}>
492492
<TabItem

0 commit comments

Comments
 (0)