chore: Improve FeatureState test coverage (#5617)

Author: khvn26

api/features/models.py

@@ -580,11 +580,11 @@ def __gt__(self, other: "FeatureState") -> bool:  # noqa: C901
         # it has a feature_segment or an identity
         return not (other.feature_segment_id or other.identity_id)
 
-    def __str__(self):  # type: ignore[no-untyped-def]
+    def __str__(self) -> str:
         s = f"Feature {self.feature.name} - Enabled: {self.enabled}"
         if self.environment is not None:
             s = f"{self.environment} - {s}"
-        elif self.identity is not None:
+        if self.identity is not None:
             s = f"Identity {self.identity.identifier} - {s}"
         return s
 

api/tests/unit/features/test_unit_features_models.py

@@ -6,6 +6,7 @@
 from django.core.exceptions import ValidationError
 from django.db.utils import IntegrityError
 from django.utils import timezone
+from pytest_lazyfixture import lazy_fixture  # type: ignore[import-untyped]
 from pytest_mock import MockerFixture
 
 from environments.identities.models import Identity
@@ -453,6 +454,53 @@ def test_feature_state_gt_operator_throws_value_error_if_different_identities(
         feature_state_identity_1 > feature_state_identity_2
 
 
+def test_feature_state_gt_operator__environment_default__returns_expected(
+    environment: Environment,
+    feature: Feature,
+    identity: Identity,
+    feature_segment: FeatureSegment,
+) -> None:
+    # When
+    feature_state = FeatureState.objects.get(feature=feature, environment=environment)
+    feature_state_identity = FeatureState.objects.create(
+        feature=feature, environment=environment, identity=identity
+    )
+    feature_state_segment = FeatureState.objects.create(
+        feature=feature,
+        environment=environment,
+        feature_segment=feature_segment,
+    )
+
+    # Then
+    assert not feature_state > feature_state_identity
+    assert not feature_state > feature_state_segment
+
+
+@pytest.mark.parametrize(
+    "feature_identity, expected_result",
+    [
+        (
+            lazy_fixture("identity"),
+            "Identity test_identity - Project Test Project - Environment Test Environment - Feature Test Feature1 - Enabled: False",
+        ),
+        (
+            None,
+            "Project Test Project - Environment Test Environment - Feature Test Feature1 - Enabled: False",
+        ),
+    ],
+)
+def test_feature_state_str__returns_expected(
+    feature_state: FeatureState,
+    feature_identity: Identity | None,
+    expected_result: str,
+) -> None:
+    # Given
+    feature_state.identity = feature_identity
+
+    # When & Then
+    assert str(feature_state) == expected_result
+
+
 @mock.patch("features.signals.trigger_feature_state_change_webhooks")
 def test_feature_state_save_calls_trigger_webhooks(
     mock_trigger_webhooks: mock.MagicMock,