Skip to content

Commit 824eb32

Browse files
committed
Simplify Segment version field with default value
1 parent 331cd9e commit 824eb32

File tree

2 files changed

+24
-7
lines changed

2 files changed

+24
-7
lines changed
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
# Generated by Django 4.2.22 on 2025-11-11 00:08
2+
3+
from django.db import migrations, models
4+
5+
6+
class Migration(migrations.Migration):
7+
8+
dependencies = [
9+
("segments", "0029_add_is_system_segment"),
10+
]
11+
12+
operations = [
13+
migrations.AlterField(
14+
model_name="historicalsegment",
15+
name="version",
16+
field=models.IntegerField(default=1, null=True),
17+
),
18+
migrations.AlterField(
19+
model_name="segment",
20+
name="version",
21+
field=models.IntegerField(default=1, null=True),
22+
),
23+
]

api/segments/models.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,7 @@ class Segment(
8787
Feature, on_delete=models.CASCADE, related_name="segments", null=True
8888
)
8989

90-
# This defaults to 1 for newly created segments.
91-
version = models.IntegerField(null=True)
90+
version = models.IntegerField(default=1, null=True)
9291

9392
version_of = models.ForeignKey(
9493
"self",
@@ -134,11 +133,6 @@ def get_skip_create_audit_log(self) -> bool:
134133

135134
return False
136135

137-
@hook(BEFORE_CREATE, when="version_of", is_now=None)
138-
def set_default_version_to_one_if_new_segment(self): # type: ignore[no-untyped-def]
139-
if self.version is None:
140-
self.version = 1
141-
142136
@hook(AFTER_CREATE, when="version_of", is_now=None)
143137
def set_version_of_to_self_if_none(self): # type: ignore[no-untyped-def]
144138
"""

0 commit comments

Comments
 (0)