feat: Add wait for trigger to release pipelines (#5523)

Author: tiagoapolo

frontend/common/services/useReleasePipelines.ts

@@ -7,32 +7,19 @@ export const releasePipelinesService = service
   .enhanceEndpoints({ addTagTypes: ['ReleasePipelines'] })
   .injectEndpoints({
     endpoints: (builder) => ({
-      createPipelineStages: builder.mutation<
-        Res['pipelineStage'],
-        Req['createPipelineStage']
-      >({
-        invalidatesTags: [{ id: 'LIST', type: 'ReleasePipelines' }],
-        query: (query: Req['createPipelineStage']) => ({
-          body: {
-            actions: query.actions,
-            environment: query.environment,
-            name: query.name,
-            order: query.order,
-            trigger: query.trigger,
-          },
-          method: 'POST',
-          url: `projects/${query.project}/release-pipelines/${query.pipeline}/stages/`,
-        }),
-      }),
       createReleasePipeline: builder.mutation<
         Res['releasePipeline'],
         Req['createReleasePipeline']
       >({
         invalidatesTags: [{ id: 'LIST', type: 'ReleasePipelines' }],
         query: (query: Req['createReleasePipeline']) => ({
-          body: { name: query.name },
+          body: {
+            description: query.description,
+            name: query.name,
+            stages: query.stages,
+          },
           method: 'POST',
-          url: `projects/${query.projectId}/release-pipelines/`,
+          url: `projects/${query.project}/release-pipelines/`,
         }),
       }),
       deleteReleasePipeline: builder.mutation<{}, Req['deleteReleasePipeline']>(
@@ -131,25 +118,9 @@ export async function getPipelineStages(
   )
 }
 
-export async function createPipelineStages(
-  store: any,
-  data: Req['createPipelineStage'],
-  options?: Parameters<
-    typeof releasePipelinesService.endpoints.createPipelineStages.initiate
-  >[1],
-) {
-  return store.dispatch(
-    releasePipelinesService.endpoints.createPipelineStages.initiate(
-      data,
-      options,
-    ),
-  )
-}
-
 // END OF FUNCTION_EXPORTS
 
 export const {
-  useCreatePipelineStagesMutation,
   useCreateReleasePipelineMutation,
   useDeleteReleasePipelineMutation,
   useGetPipelineStageQuery,

frontend/common/types/requests.ts

@@ -78,11 +78,16 @@ export interface StageActionRequest {
   action_body: { enabled: boolean; segment_id?: number }
 }
 
+export type ReleasePipelineRequest = {
+  project: number
+  name: string
+  description?: string
+  stages: PipelineStageRequest[]
+}
+
 export type PipelineStageRequest = {
   name: string
-  project: number
   environment: number
-  pipeline: number
   order: number
   trigger: StageTrigger
   actions: StageActionRequest[]
@@ -698,11 +703,7 @@ export type Req = {
   updateOnboarding: Partial<Onboarding>
   getReleasePipelines: PagedRequest<{ projectId: number }>
   getReleasePipeline: { projectId: number; pipelineId: number }
-  createReleasePipeline: {
-    projectId: number
-    name: string
-    status: PipelineStatus
-  }
+  createReleasePipeline: ReleasePipelineRequest
   getPipelineStages: PagedRequest<{
     projectId: number
     pipelineId: number
@@ -712,7 +713,6 @@ export type Req = {
     pipelineId: number
     stageId: number
   }
-  createPipelineStage: PipelineStageRequest
   deleteReleasePipeline: {
     projectId: number
     pipelineId: number

frontend/common/types/responses.ts

@@ -1,7 +1,3 @@
-// eslint-disable-next-line @typescript-eslint/no-empty-interface
-
-import { StageActionRequest } from './requests'
-
 export type EdgePagedResponse<T> = PagedResponse<T> & {
   last_evaluated_key?: string
   pages?: (string | undefined)[]
@@ -817,21 +813,28 @@ export enum PipelineStatus {
   ACTIVE = 'ACTIVE',
 }
 
-export type ReleasePipeline = {
+export interface ReleasePipeline {
   id: number
-  status: PipelineStatus
-  stages_count: number
-  flags_count: number
   name: string
   project: number
+  description: string
+  stages_count: number
+  published_at: string
+  published_by: number
+  features_count: number
+}
+
+export interface SingleReleasePipeline extends ReleasePipeline {
+  stages: PipelineStage[]
+  completed_features: number[]
 }
 
 export enum StageTriggerType {
   ON_ENTER = 'ON_ENTER',
   WAIT_FOR = 'WAIT_FOR',
 }
 
-export type StageTriggerBody = string | null
+export type StageTriggerBody = { wait_for?: string } | null
 
 export type StageTrigger = {
   trigger_type: StageTriggerType
@@ -842,20 +845,23 @@ export enum StageActionType {
   TOGGLE_FEATURE = 'TOGGLE_FEATURE',
   TOGGLE_FEATURE_FOR_SEGMENT = 'TOGGLE_FEATURE_FOR_SEGMENT',
 }
-// TODO: Check if this is correct
-export interface StageActionResponse
-  extends Omit<StageActionRequest, 'action_body'> {
-  action_body: string
+
+export type StageActionBody = { enabled: boolean; segment_id?: number }
+export interface StageAction {
+  id: number
+  action_type: StageActionType
+  action_body: StageActionBody
 }
 
-export interface PipelineStage {
+export type PipelineStage = {
   id: number
   name: string
   pipeline: number
   environment: number
   order: number
   trigger: StageTrigger
-  actions: StageActionResponse[]
+  actions: StageAction[]
+  features: number[]
 }
 
 export type Res = {
@@ -1008,7 +1014,7 @@ export type Res = {
   onboarding: {}
   userPermissions: UserPermissions
   releasePipelines: PagedResponse<ReleasePipeline>
-  releasePipeline: ReleasePipeline
+  releasePipeline: SingleReleasePipeline
   pipelineStages: PagedResponse<PipelineStage>
   pipelineStage: PipelineStage
   // END OF TYPES

frontend/web/components/pages/CreateReleasePipelinePage.tsx

@@ -1,16 +1,5 @@
 import CreateReleasePipeline from 'components/release-pipelines/CreateReleasePipeline'
 
-type CreateReleasePipelinePageType = {
-  match: {
-    params: {
-      projectId: string
-    }
-  }
-}
-
-export default function CreateReleasePipelinePage({
-  match,
-}: CreateReleasePipelinePageType) {
-  const { projectId } = match.params
-  return <CreateReleasePipeline projectId={projectId} />
+export default function CreateReleasePipelinePage() {
+  return <CreateReleasePipeline />
 }

frontend/web/components/pages/ReleasePipelineDetailPage.tsx

@@ -1,17 +1,5 @@
 import ReleasePipelineDetail from 'components/release-pipelines/ReleasePipelineDetail'
 
-type ReleasePipelineDetailPageType = {
-  match: {
-    params: {
-      projectId: string
-      id: string
-    }
-  }
-}
-
-export default function ReleasePipelineDetailPage({
-  match,
-}: ReleasePipelineDetailPageType) {
-  const { projectId } = match.params
-  return <ReleasePipelineDetail projectId={projectId} id={match.params.id} />
+export default function ReleasePipelineDetailPage() {
+  return <ReleasePipelineDetail />
 }