Skip to content

Commit 00ceb44

Browse files
committed
Solve several Codacy issues
1 parent ef12bfe commit 00ceb44

File tree

5 files changed

+0
-23
lines changed

5 files changed

+0
-23
lines changed

src/main/java/com/adventofcode/flashk/day17/ClumsyCrucibleRefactor.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
package com.adventofcode.flashk.day17;
22

33
import com.adventofcode.flashk.common.Vector2;
4-
import org.apache.commons.lang3.tuple.ImmutablePair;
5-
import org.apache.commons.lang3.tuple.ImmutableTriple;
64
import org.apache.commons.lang3.tuple.Pair;
7-
import org.apache.commons.lang3.tuple.Triple;
85

96
import java.util.List;
107
import java.util.Optional;

src/main/java/com/adventofcode/flashk/day17/Tile.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
import java.util.HashSet;
1111
import java.util.List;
1212
import java.util.Set;
13-
import java.util.stream.Stream;
14-
1513

1614
@Getter
1715
@Setter

src/main/java/com/adventofcode/flashk/day19/Aplenty.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ public Aplenty(List<String> inputs) {
3232
workflowPerPart.put(part, StringUtils.EMPTY);
3333
}
3434
}
35-
int a = 3;
3635
}
3736

3837
public long solveA() {

src/main/java/com/adventofcode/flashk/day19/Rule.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ public class Rule {
1010
private static final Pattern FULL_RULE_PATTERN = Pattern.compile("([xmas])([><])(\\d*):(\\w*)");
1111

1212
private static final char LESS_THAN = '<';
13-
private static final char GREATER_THAN = '>';
1413

1514
private char letter;
1615
private char condition;

src/main/java/com/adventofcode/flashk/day19/Workflow.java

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
import java.util.Arrays;
77
import java.util.List;
8-
import java.util.Optional;
98
import java.util.regex.Matcher;
109
import java.util.regex.Pattern;
1110
import java.util.stream.Collectors;
@@ -28,21 +27,6 @@ public Workflow(String input) {
2827
String[] rulesArray = rulesString.split(",");
2928
rules = Arrays.stream(rulesArray).map(Rule::new).collect(Collectors.toList());
3029

31-
// TODO minor improvement
32-
// some workflows lead always to the same output workflow, in that case
33-
// rules can be directely bypassed.
34-
boolean sameWorkflows = true;
35-
String workflowName = rules.get(0).getDestinationWorkflow();
36-
for(Rule rule : rules) {
37-
if(!rule.getDestinationWorkflow().equals(workflowName)) {
38-
sameWorkflows = false;
39-
}
40-
}
41-
42-
if(sameWorkflows) {
43-
rules.clear();
44-
rules.add(new Rule(workflowName));
45-
}
4630
}
4731

4832
public String run(Part part) {

0 commit comments

Comments
 (0)