From 0ceeb4b9dd378873ed4fcaed30016e3a10fe87c3 Mon Sep 17 00:00:00 2001 From: alvinsj Date: Sat, 9 May 2015 22:50:01 +0700 Subject: [PATCH 1/2] fixed listview positioning, by taking top/left in consideration --- lib/ListView.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/ListView.js b/lib/ListView.js index 7046cd8..d4b61cd 100644 --- a/lib/ListView.js +++ b/lib/ListView.js @@ -56,12 +56,15 @@ var ListView = React.createClass({ renderItem: function (itemIndex) { var item = this.props.itemGetter(itemIndex, this.state.scrollTop); var itemHeight = this.props.itemHeightGetter(); + var listViewTop = this.props.style.top || 0; + var listViewLeft = this.props.style.left || 0; + var style = { - top: 0, - left: 0, + top: listViewTop, + left: listViewLeft, width: this.props.style.width, height: itemHeight, - translateY: (itemIndex * itemHeight) - this.state.scrollTop, + translateY: (itemIndex * itemHeight) - this.state.scrollTop + listViewTop, zIndex: itemIndex }; From 52f9498d9d9faf848911f765ae704ebd38c380f0 Mon Sep 17 00:00:00 2001 From: alvinsj Date: Sat, 9 May 2015 22:57:41 +0700 Subject: [PATCH 2/2] missing translateX --- lib/ListView.js | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ListView.js b/lib/ListView.js index d4b61cd..46a6a01 100644 --- a/lib/ListView.js +++ b/lib/ListView.js @@ -64,6 +64,7 @@ var ListView = React.createClass({ left: listViewLeft, width: this.props.style.width, height: itemHeight, + translateX: listViewLeft, translateY: (itemIndex * itemHeight) - this.state.scrollTop + listViewTop, zIndex: itemIndex };