feat(lint): use more accurate config

Author: fumiama

.golangci.yml

@@ -8,19 +8,97 @@ formatters:
 linters:
   default: none
   enable:
-    - errcheck
-    - staticcheck
-    - govet
-    - ineffassign
-    - unused
-    - misspell
-    - unconvert
-    - revive
+    # --- Bug & correctness ---
+    - errcheck       # unchecked error returns
+    - govet          # go vet suspicious constructs
+    - staticcheck    # comprehensive static analysis
+    - nilerr         # returning nil where error is expected
+    - bodyclose      # unclosed HTTP response bodies (factory/img.go)
+
+    # --- Code quality ---
+    - ineffassign    # useless assignments
+    - unused         # unused code
+    - unconvert      # unnecessary type conversions
+    - wastedassign   # overwritten-before-read assignments
+    - copyloopvar    # loop variable capture issues
+
+    # --- Performance ---
+    - prealloc       # slice pre-allocation hints
+    - mirror         # bytes/strings mirror-function suggestions
+    - perfsprint     # faster fmt.Sprintf alternatives
+
+    # --- Style & consistency ---
+    - revive         # superset of golint
+    - misspell       # common English misspellings
+    - dupword        # duplicate words in comments / strings
+    - whitespace     # unnecessary leading/trailing blank lines
+    - goprintffuncname # printf-like functions end with 'f'
+    - gocritic       # opinionated but high-signal checks
+    - asciicheck     # non-ASCII identifiers
+    - bidichk        # dangerous bidi unicode sequences
+
+    # --- Security ---
+    - gosec          # security-oriented checks
+
+    # --- Modernization ---
+    - intrange       # for i := 0; i < n; i++ → for i := range n
+    - usestdlibvars  # prefer stdlib constants (http.StatusOK, etc.)
+    - modernize      # suggest modern Go idioms
+
+  settings:
+    gocritic:
+      enabled-tags:
+        - diagnostic
+        - performance
+      disabled-checks:
+        - hugeParam          # graphics functions pass large structs by value on purpose
+        - rangeValCopy       # same reason
+        - whyNoLint          # not using nolint directives
+        - commentedOutCode   # example/test files legitimately keep commented-out alternatives
+
+    gosec:
+      excludes:
+        - G103  # unsafe.Pointer — intentional for pixel manipulation and GPU interop
+        - G107  # HTTP request with variable URL — expected for image loading from URLs
+        - G115  # integer overflow conversion — deliberate in pixel/color math
+        - G304  # file path from variable — this IS an image-loading library
+        - G306  # poor file permissions — not applicable
+        - G401  # weak crypto (md5) — used only for display hashing, not security
+        - G404  # weak RNG — used for k-means color quantization, not security
+        - G501  # blocklisted import crypto/md5 — same as G401
+
+    revive:
+      rules:
+        - name: blank-imports
+        - name: context-as-argument
+        - name: dot-imports
+        - name: error-return
+        - name: error-strings
+        - name: error-naming
+        - name: exported
+        - name: increment-decrement
+        - name: indent-error-flow
+        - name: package-comments
+        - name: range
+        - name: receiver-naming
+        - name: time-naming
+        - name: unexported-return
+        - name: unreachable-code
+        - name: unused-parameter
+        - name: superfluous-else
+
+    prealloc:
+      simple: true
+      for-loops: false  # avoid false positives in complex rendering loops
+
   exclusions:
     rules:
+      # Exclude non-Go sources from typecheck
       - path: \.cpp$
         linters:
           - typecheck
+
+      # cmd/ is not part of the library API — relax everything
       - path: ^cmd/
         linters:
           - errcheck
@@ -31,10 +109,19 @@ linters:
           - misspell
           - unconvert
           - revive
+
+      # Deferred close errors are almost never actionable
       - linters:
           - errcheck
         source: "^\\s*defer "
 
+      # Test files: relax security, pre-alloc, and HTTP body checks
+      - path: _test\.go$
+        linters:
+          - gosec
+          - prealloc
+          - bodyclose
+
 issues:
   max-issues-per-linter: 0
   max-same-issues: 0

color.go

@@ -36,7 +36,7 @@ func takecolor(img image.Image, k int) []color.RGBA {
 
 	// 初始化k个聚类中心
 	clusters := make([]color.RGBA, k)
-	for i := 0; i < k; i++ {
+	for i := range k {
 		clusters[i] = pixels[rand.Intn(len(pixels))]
 	}
 
@@ -57,7 +57,7 @@ func takecolor(img image.Image, k int) []color.RGBA {
 
 		// 计算每个聚类的新中心
 		newClusters := make([]color.RGBA, k)
-		for i := 0; i < k; i++ {
+		for i := range k {
 			var r, g, b uint32
 			n := 0
 			for j, cluster := range clusterAssignments {
@@ -99,7 +99,7 @@ func clustersEqual(a, b []color.RGBA) bool {
 	if len(a) != len(b) {
 		return false
 	}
-	for i := 0; i < len(a); i++ {
+	for i := range a {
 		if a[i] != b[i] {
 			return false
 		}

color_test.go

@@ -13,8 +13,8 @@ import (
 // solidImage 创建一个全部填充为指定颜色的 image.Image
 func solidImage(w, h int, c color.RGBA) image.Image {
 	img := image.NewRGBA(image.Rect(0, 0, w, h))
-	for y := 0; y < h; y++ {
-		for x := 0; x < w; x++ {
+	for y := range h {
+		for x := range w {
 			img.SetRGBA(x, y, c)
 		}
 	}
@@ -24,8 +24,8 @@ func solidImage(w, h int, c color.RGBA) image.Image {
 // twoColorImage 创建左半部分为 c1、右半部分为 c2 的图像
 func twoColorImage(w, h int, c1, c2 color.RGBA) image.Image {
 	img := image.NewRGBA(image.Rect(0, 0, w, h))
-	for y := 0; y < h; y++ {
-		for x := 0; x < w; x++ {
+	for y := range h {
+		for x := range w {
 			if x < w/2 {
 				img.SetRGBA(x, y, c1)
 			} else {
@@ -135,7 +135,7 @@ func TestDistance_Symmetry(t *testing.T) {
 
 func TestDistance_NonNegative(t *testing.T) {
 	rng := rand.New(rand.NewSource(42))
-	for i := 0; i < 100; i++ {
+	for range 100 {
 		a := color.RGBA{uint8(rng.Intn(256)), uint8(rng.Intn(256)), uint8(rng.Intn(256)), 255}
 		b := color.RGBA{uint8(rng.Intn(256)), uint8(rng.Intn(256)), uint8(rng.Intn(256)), 255}
 		got := distance(a, b)
@@ -263,7 +263,7 @@ func TestTakecolor_TwoDistinctColors(t *testing.T) {
 	// 多次运行，验证算法至少能在 30 次尝试中有一次正确分离两种颜色。
 	img := twoColorImage(20, 20, Red, Blue)
 	const maxAttempts = 30
-	for attempt := 0; attempt < maxAttempts; attempt++ {
+	for range maxAttempts {
 		result := takecolor(img, 2)
 		if len(result) == 2 && colorInSlice(Red, result, 5) && colorInSlice(Blue, result, 5) {
 			return // 成功分离，测试通过
@@ -286,8 +286,8 @@ func TestTakecolor_Deterministic_SolidImage(t *testing.T) {
 func TestTakecolor_AllClustersHaveValidRGB(t *testing.T) {
 	rng := rand.New(rand.NewSource(99))
 	img := image.NewRGBA(image.Rect(0, 0, 16, 16))
-	for y := 0; y < 16; y++ {
-		for x := 0; x < 16; x++ {
+	for y := range 16 {
+		for x := range 16 {
 			img.SetRGBA(x, y, color.RGBA{
 				uint8(rng.Intn(256)),
 				uint8(rng.Intn(256)),
@@ -310,7 +310,7 @@ func TestTakecolor_AllClustersHaveValidRGB(t *testing.T) {
 // ---- Benchmark ----
 
 func BenchmarkSq(b *testing.B) {
-	for i := 0; i < b.N; i++ {
+	for i := range b.N {
 		sq(float64(i))
 	}
 }
@@ -319,7 +319,7 @@ func BenchmarkDistance(b *testing.B) {
 	a := color.RGBA{100, 150, 200, 255}
 	c := color.RGBA{50, 80, 30, 255}
 	b.ResetTimer()
-	for i := 0; i < b.N; i++ {
+	for range b.N {
 		distance(a, c)
 	}
 }
@@ -328,7 +328,7 @@ func BenchmarkClustersEqual_Equal(b *testing.B) {
 	a := []color.RGBA{{255, 0, 0, 255}, {0, 255, 0, 255}, {0, 0, 255, 255}, {128, 128, 128, 255}}
 	c := []color.RGBA{{255, 0, 0, 255}, {0, 255, 0, 255}, {0, 0, 255, 255}, {128, 128, 128, 255}}
 	b.ResetTimer()
-	for i := 0; i < b.N; i++ {
+	for range b.N {
 		clustersEqual(a, c)
 	}
 }
@@ -337,57 +337,57 @@ func BenchmarkClustersEqual_NotEqual(b *testing.B) {
 	a := []color.RGBA{{255, 0, 0, 255}, {0, 255, 0, 255}, {0, 0, 255, 255}, {128, 128, 128, 255}}
 	c := []color.RGBA{{255, 0, 0, 255}, {0, 255, 0, 255}, {0, 0, 255, 255}, {200, 200, 200, 255}}
 	b.ResetTimer()
-	for i := 0; i < b.N; i++ {
+	for range b.N {
 		clustersEqual(a, c)
 	}
 }
 
 func BenchmarkTakecolor_16x16_K3(b *testing.B) {
 	rng := rand.New(rand.NewSource(42))
 	img := image.NewRGBA(image.Rect(0, 0, 16, 16))
-	for y := 0; y < 16; y++ {
-		for x := 0; x < 16; x++ {
+	for y := range 16 {
+		for x := range 16 {
 			img.SetRGBA(x, y, color.RGBA{uint8(rng.Intn(256)), uint8(rng.Intn(256)), uint8(rng.Intn(256)), 255})
 		}
 	}
 	b.ResetTimer()
-	for i := 0; i < b.N; i++ {
+	for range b.N {
 		takecolor(img, 3)
 	}
 }
 
 func BenchmarkTakecolor_64x64_K4(b *testing.B) {
 	rng := rand.New(rand.NewSource(42))
 	img := image.NewRGBA(image.Rect(0, 0, 64, 64))
-	for y := 0; y < 64; y++ {
-		for x := 0; x < 64; x++ {
+	for y := range 64 {
+		for x := range 64 {
 			img.SetRGBA(x, y, color.RGBA{uint8(rng.Intn(256)), uint8(rng.Intn(256)), uint8(rng.Intn(256)), 255})
 		}
 	}
 	b.ResetTimer()
-	for i := 0; i < b.N; i++ {
+	for range b.N {
 		takecolor(img, 4)
 	}
 }
 
 func BenchmarkTakecolor_128x128_K8(b *testing.B) {
 	rng := rand.New(rand.NewSource(42))
 	img := image.NewRGBA(image.Rect(0, 0, 128, 128))
-	for y := 0; y < 128; y++ {
-		for x := 0; x < 128; x++ {
+	for y := range 128 {
+		for x := range 128 {
 			img.SetRGBA(x, y, color.RGBA{uint8(rng.Intn(256)), uint8(rng.Intn(256)), uint8(rng.Intn(256)), 255})
 		}
 	}
 	b.ResetTimer()
-	for i := 0; i < b.N; i++ {
+	for range b.N {
 		takecolor(img, 8)
 	}
 }
 
 func BenchmarkTakecolor_SolidColor_K5(b *testing.B) {
 	img := solidImage(64, 64, color.RGBA{200, 100, 50, 255})
 	b.ResetTimer()
-	for i := 0; i < b.N; i++ {
+	for range b.N {
 		takecolor(img, 5)
 	}
 }

context.go

@@ -930,7 +930,7 @@ func (dc *Context) DrawRoundedRectangle(x, y, w, h, r float64) {
 // DrawEllipticalArc 绘制以 (x, y) 为中心的椭圆弧。
 func (dc *Context) DrawEllipticalArc(x, y, rx, ry, angle1, angle2 float64) {
 	const n = 16
-	for i := 0; i < n; i++ {
+	for i := range n {
 		p1 := float64(i+0) / n
 		p2 := float64(i+1) / n
 		a1 := angle1 + (angle2-angle1)*p1
@@ -989,7 +989,7 @@ func (dc *Context) DrawRegularPolygon(n int, x, y, r, rotation float64) {
 		rotation += angle / 2
 	}
 	dc.NewSubPath()
-	for i := 0; i < n; i++ {
+	for i := range n {
 		a := rotation + angle*float64(i)
 		dc.LineTo(x+r*math.Cos(a), y+r*math.Sin(a))
 	}
@@ -1000,7 +1000,7 @@ func (dc *Context) DrawRegularPolygon(n int, x, y, r, rotation float64) {
 //
 // LoadImage 从指定路径加载图像并绘制到 (x, y) 坐标。
 func (dc *Context) LoadImage(path string, x, y int) error {
-	img, err := fio.LoadImage(path) //添加图片
+	img, err := fio.LoadImage(path) // 添加图片
 	if err != nil {
 		return err
 	}