A very rare issue seems to be fixed, due to which after 20-30 minutes of listening to a large amount of music, the sound may disappear, and the text of the current position of the track will not move.

Author: Flone-dnb

ide/BloodyPlayer.pro.user

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE QtCreatorProject>
-<!-- Written by QtCreator 4.9.2, 2019-08-19T15:14:23. -->
+<!-- Written by QtCreator 4.9.2, 2019-08-30T12:23:04. -->
 <qtcreator>
  <data>
   <variable>EnvironmentId</variable>

src/Model/AudioService/audioservice.cpp

@@ -247,6 +247,11 @@ void AudioService::addTrack(const wchar_t *pFilePath)
         monitor.detach();
     }
 
+    FMOD_RESULT result = pSystem->update();
+    if (result)
+    {
+        pMainWindow->showMessageBox( true, std::string("AudioService::addTrack::FMOD::System::update() failed. Error: ") + std::string(FMOD_ErrorString(result)) );
+    }
 
     mtxThreadLoadAddTrack.unlock();
 }
@@ -429,6 +434,12 @@ void AudioService::playTrack(size_t iTrackIndex, bool bDontLockMutex)
             pMainWindow->showMessageBox(false, "Something went wrong and we could not play the track.");
         }
 
+        FMOD_RESULT result = pSystem->update();
+        if (result)
+        {
+            pMainWindow->showMessageBox( true, std::string("AudioService::playTrack::FMOD::System::update() failed. Error: ") + std::string(FMOD_ErrorString(result)) );
+        }
+
         pMainWindow->setPlayingOnTrack(iCurrentlyPlayingTrackIndex);
     }
     else
@@ -458,6 +469,13 @@ void AudioService::setTrackPos(unsigned int graphPos)
         }
     }
 
+    FMOD_RESULT result;
+    result = pSystem->update();
+    if (result)
+    {
+        pMainWindow->showMessageBox( true, std::string("AudioService::setTrackPos::FMOD::System::update() failed. Error: ") + std::string(FMOD_ErrorString(result)) );
+    }
+
     mtxTracksVec.unlock();
 }
 
@@ -483,6 +501,13 @@ void AudioService::pauseTrack()
         }
     }
 
+    FMOD_RESULT result;
+    result = pSystem->update();
+    if (result)
+    {
+        pMainWindow->showMessageBox( true, std::string("AudioService::pauseTrack::FMOD::System::update() failed. Error: ") + std::string(FMOD_ErrorString(result)) );
+    }
+
     mtxTracksVec.unlock();
 }
 
@@ -619,6 +644,13 @@ void AudioService::removeTrack(size_t iTrackIndex)
         delete tracks[iTrackIndex];
         tracks.erase( tracks.begin() + iTrackIndex );
 
+        FMOD_RESULT result;
+        result = pSystem->update();
+        if (result)
+        {
+            pMainWindow->showMessageBox( true, std::string("AudioService::removeTrack::FMOD::System::update() failed. Error: ") + std::string(FMOD_ErrorString(result)) );
+        }
+
         mtxGetCurrentDrawingIndex.unlock();
     }
     else
@@ -1076,6 +1108,12 @@ void AudioService::monitorTrack()
                 // The track is ended, play next
                 tracks[iCurrentlyPlayingTrackIndex]->reCreateTrack(fCurrentVolume);
 
+                FMOD_RESULT result = pSystem->update();
+                if (result)
+                {
+                    pMainWindow->showMessageBox(true, std::string("AudioService::monitorTrack::FMOD::System::update() failed. Error: ") + FMOD_ErrorString(result));
+                }
+
                 if (bRepeatTrack)
                 {
                     // Or not
@@ -1104,6 +1142,8 @@ void AudioService::monitorTrack()
             }
         }
 
+        pSystem->update();
+
         mtxTracksVec.unlock();
 
         std::this_thread::sleep_for(std::chrono::milliseconds(MONITOR_TRACK_INTERVAL_MS));
@@ -1116,6 +1156,16 @@ void AudioService::drawGraph(size_t* iTrackIndex)
     bDrawing = true;
 
 
+    // default: 16384
+    // "If FMOD_TIMEUNIT_RAWBYTES is used, the memory allocated is two times the size passed in, because fmod allocates a double buffer."
+    // 131072 * 2 = 256 kB (x8 times bigger than default) to speed up our graph draw (to speed up our readData() calls)
+    FMOD_RESULT fresult = pSystem->setStreamBufferSize(131072, FMOD_TIMEUNIT_RAWBYTES);
+    if (fresult)
+    {
+        pMainWindow->showMessageBox( true, std::string("AudioService::AudioService::FMOD::System::setStreamBufferSize() failed. Error: ") + std::string(FMOD_ErrorString(fresult)) );
+    }
+
+
     pMainWindow->clearGraph();
 
     // this value combines 'iSamplesInOne' samples in one to store less points for graph in memory
@@ -1185,6 +1235,16 @@ void AudioService::drawGraph(size_t* iTrackIndex)
 
     mtxGetCurrentDrawingIndex.unlock();
 
+
+
+    // set to default: 16384
+    fresult = pSystem->setStreamBufferSize(16384, FMOD_TIMEUNIT_RAWBYTES);
+    if (fresult)
+    {
+        pMainWindow->showMessageBox( true, std::string("AudioService::AudioService::FMOD::System::setStreamBufferSize() failed. Error: ") + std::string(FMOD_ErrorString(fresult)) );
+    }
+
+
     bDrawing = false;
     mtxDrawGraph.unlock();
 }

src/Model/Track/track.cpp

@@ -285,72 +285,20 @@ bool Track::playTrack(float fVolume)
             return false;
         }
 
-        // Is track paused?
-        bool bPausedTrack;
-        result = pChannel->getPaused(&bPausedTrack);
+
+        // Check if it's actually playing
+        bool bIsPlaying;
+        result = pChannel->isPlaying(&bIsPlaying);
         if (result)
         {
-            pMainWindow->showMessageBox( true, std::string("Track::playTrack::FMOD::Channel::getPaused() failed. Error: ") + std::string(FMOD_ErrorString(result)) );
+            pMainWindow->showMessageBox( true, std::string("Track::playTrack::FMOD::Channel::setPaused() failed. Error: ") + std::string(FMOD_ErrorString(result)) );
             return false;
         }
 
-        if (bPausedTrack)
-        {
-            // Unpause track is it's paused
-            // 'bPaused = false' in the end of this function
-            result = pChannel->setPaused(false);
-            if (result)
-            {
-                pMainWindow->showMessageBox( true, std::string("Track::playTrack::FMOD::Channel::setPaused() failed. Error: ") + std::string(FMOD_ErrorString(result)) );
-                return false;
-            }
-        }
-        else
+        if (bIsPlaying)
         {
-            // The track is not paused, maybe it's stopped?
-
-            bool bIsPlaying;
-            result = pChannel->isPlaying(&bIsPlaying);
-            if (result)
-            {
-                pMainWindow->showMessageBox( true, std::string("Track::playTrack::FMOD::Channel::setPaused() failed. Error: ") + std::string(FMOD_ErrorString(result)) );
-                return false;
-            }
-
-            if (bIsPlaying)
-            {
-                // The track is plaing and user pressed Play so now we just need to start track from the beginning.
-                setPositionInMS(0);
-                pChannel->setPaused(true);
-            }
-            else
-            {
-                // The track is stopped (probably it was playing and ended).
-                // Now every operation with 'pChannel' will return error because sound is ended.
-                // We will recreate the track:
-
-                result = pChannel->stop();
-                if (result)
-                {
-                    pMainWindow->showMessageBox( true, std::string("Track::playTrack::FMOD::Channel::stop() failed. Error: ") + std::string(FMOD_ErrorString(result)) );
-                    return false;
-                }
-
-                // And play it again.
-                result = pSystem->playSound(pSound, nullptr, true, &pChannel);
-                if (result)
-                {
-                    pMainWindow->showMessageBox( true, std::string("Track::playTrack::FMOD::System::playSound() failed. Error: ") + std::string(FMOD_ErrorString(result)) );
-                    return false;
-                }
-
-                result = pChannel->setVolume(fVolume);
-                if (result)
-                {
-                    pMainWindow->showMessageBox( true, std::string("Track::playTrack::FMOD::Channel::setVolume() failed. Error: ") + std::string(FMOD_ErrorString(result)) );
-                    return false;
-                }
-            }
+            // The track is plaing and user pressed Play so now we just need to start track from the beginning.
+            setPositionInMS(0);
         }
 
         if ( (fSpeedByFreq == 1.0f) && (fSpeedByTime == 1.0f) )

src/globalparams.h

@@ -2,7 +2,7 @@
 
 #define MAX_CHANNELS 2000
 #define DEFAULT_VOLUME 0.75f
-#define MONITOR_TRACK_INTERVAL_MS 400
+#define MONITOR_TRACK_INTERVAL_MS 200
 #define MAX_TIME_ERROR_MS 50
 
 // graph