Skip to content

Commit 43d8fe1

Browse files
committed
Remove CouldNotFindResourceDictionaries diagnostic
1 parent d6ff876 commit 43d8fe1

File tree

3 files changed

+4
-23
lines changed

3 files changed

+4
-23
lines changed

Flow.Launcher.Localization.SourceGenerators/AnalyzerReleases.Unshipped.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,9 @@
44

55
Rule ID | Category | Severity | Notes
66
--------|----------|----------|-------
7-
FLSG0001 | Localization | Warning | FLSG0001_CouldNotFindResourceDictionaries
7+
FLSG0001 | Localization | Warning | FLSG0001_LocalizationKeyUnused
88
FLSG0002 | Localization | Warning | FLSG0002_CouldNotFindPluginEntryClass
99
FLSG0003 | Localization | Warning | FLSG0003_CouldNotFindContextProperty
1010
FLSG0004 | Localization | Warning | FLSG0004_ContextPropertyNotStatic
1111
FLSG0005 | Localization | Warning | FLSG0005_ContextPropertyIsPrivate
1212
FLSG0006 | Localization | Warning | FLSG0006_ContextPropertyIsProtected
13-
FLSG0007 | Localization | Warning | FLSG0007_LocalizationKeyUnused

Flow.Launcher.Localization.SourceGenerators/Localize/LocalizeSourceGenerator.cs

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -84,15 +84,6 @@ private void Execute(SourceProductionContext spc,
8484
ImmutableArray<AdditionalText> AdditionalTexts) data)
8585
{
8686
var xamlFiles = data.AdditionalTexts;
87-
if (xamlFiles.Length == 0)
88-
{
89-
spc.ReportDiagnostic(Diagnostic.Create(
90-
SourceGeneratorDiagnostics.CouldNotFindResourceDictionaries,
91-
Location.None
92-
));
93-
return;
94-
}
95-
9687
var compilation = data.Item1.Compilation;
9788
var configOptions = data.Item1.Item1.ConfigOptionsProvider;
9889
var pluginClasses = data.Item1.Item1.Item1.PluginClassInfos;

Flow.Launcher.Localization.SourceGenerators/SourceGeneratorDiagnostics.cs

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@ namespace Flow.Launcher.Localization.SourceGenerators
55
{
66
public static class SourceGeneratorDiagnostics
77
{
8-
public static readonly DiagnosticDescriptor CouldNotFindResourceDictionaries = new DiagnosticDescriptor(
8+
public static readonly DiagnosticDescriptor LocalizationKeyUnused = new DiagnosticDescriptor(
99
"FLSG0001",
10-
"Could not find resource dictionaries",
11-
"Could not find resource dictionaries. There must be a file named [LANG].xaml file (for example, en.xaml), and it must be specified in <AdditionalFiles /> in your .csproj file.",
10+
"Localization key is unused",
11+
$"Method `{Constants.ClassName}.{{0}}` is never used",
1212
"Localization",
1313
DiagnosticSeverity.Warning,
1414
isEnabledByDefault: true
@@ -58,14 +58,5 @@ public static class SourceGeneratorDiagnostics
5858
DiagnosticSeverity.Warning,
5959
isEnabledByDefault: true
6060
);
61-
62-
public static readonly DiagnosticDescriptor LocalizationKeyUnused = new DiagnosticDescriptor(
63-
"FLSG0007",
64-
"Localization key is unused",
65-
$"Method `{Constants.ClassName}.{{0}}` is never used",
66-
"Localization",
67-
DiagnosticSeverity.Warning,
68-
isEnabledByDefault: true
69-
);
7061
}
7162
}

0 commit comments

Comments
 (0)