Fixed incorrect icon url #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to Unity Projects Launcher-8de584c0-f855-4825-8886-65e670ebe441.json
Contributor
|
Hi, please resolve conflicts so we can merge this pr. thx. |
auto-merge was automatically disabled
December 17, 2024 14:58
Head branch was pushed to by a user without write access
plugins/Unity Projects Launcher-8de584c0-f855-4825-8886-65e670ebe441.json
Outdated
Show resolved
Hide resolved
VictoriousRaptor
approved these changes
Dec 17, 2024
VictoriousRaptor
merged commit d4f65eb
into
Flow-Launcher:plugin_api_v2
5 checks passed
Member
|
Hmm, thought the validation check would have caught that error. |
Contributor
Author
I think it would have to check if the URL's HTTP response is 200. to catch this error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed invalid url for the Icon path which i haven't noticed before.