Improve code quality

Author: Jack251970

Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs

@@ -161,7 +161,7 @@ internal async Task InstallOrUpdateAsync(UserPlugin plugin)
 
                     if (canReportProgress && 
                         (prgBox = Context.API.ShowProgressBox($"Download {plugin.Name}...", () =>
-                    {
+                        {
                             httpClient.CancelPendingRequests();
                             downloadCancelled = true;
                             prgBox = null;
@@ -209,15 +209,11 @@ internal async Task InstallOrUpdateAsync(UserPlugin plugin)
                 else
                 {
                     filePath = plugin.LocalInstallPath;
-                Install(plugin, filePath);
-            }
+                    Install(plugin, filePath);
+                }
             }
             catch (HttpRequestException e)
             {
-                Context.API.ShowMsgError(
-                    string.Format(Context.API.GetTranslation("plugin_pluginsmanager_downloading_plugin"), plugin.Name),
-                    Context.API.GetTranslation("plugin_pluginsmanager_download_error"));
-                Log.Exception("PluginsManager", "An error occurred while downloading plugin", e);
                 // force close progress box
                 Application.Current.Dispatcher.Invoke(() =>
                 {
@@ -227,14 +223,17 @@ internal async Task InstallOrUpdateAsync(UserPlugin plugin)
                         prgBox = null;
                     }
                 });
+
+                // show error message
+                Context.API.ShowMsgError(
+                    string.Format(Context.API.GetTranslation("plugin_pluginsmanager_downloading_plugin"), plugin.Name),
+                    Context.API.GetTranslation("plugin_pluginsmanager_download_error"));
+                Log.Exception("PluginsManager", "An error occurred while downloading plugin", e);
+
                 return;
             }
             catch (Exception e)
             {
-                Context.API.ShowMsgError(Context.API.GetTranslation("plugin_pluginsmanager_install_error_title"),
-                    string.Format(Context.API.GetTranslation("plugin_pluginsmanager_install_error_subtitle"),
-                        plugin.Name));
-                Log.Exception("PluginsManager", "An error occurred while downloading plugin", e);
                 // force close progress box
                 Application.Current.Dispatcher.Invoke(() =>
                 {
@@ -244,6 +243,13 @@ internal async Task InstallOrUpdateAsync(UserPlugin plugin)
                         prgBox = null;
                     }
                 });
+
+                // show error message
+                Context.API.ShowMsgError(Context.API.GetTranslation("plugin_pluginsmanager_install_error_title"),
+                    string.Format(Context.API.GetTranslation("plugin_pluginsmanager_install_error_subtitle"),
+                        plugin.Name));
+                Log.Exception("PluginsManager", "An error occurred while downloading plugin", e);
+
                 return;
             }