1. Change Get method Name to GetAsync

2. Manually replace "#" with "%23" to solve the similar issue in Explorer plugin
3. Add GetAsync method with Uri as argument
4. Remove unused encoding argument
5. Change exception type for WebSearch Plguin
6. Update Comment

Author: taooceros

Flow.Launcher.Core/Updater.cs

@@ -133,7 +133,7 @@ private async Task<UpdateManager> GitHubUpdateManager(string repository)
             var uri = new Uri(repository);
             var api = $"https://api.github.com/repos{uri.AbsolutePath}/releases";
 
-            var json = await Http.Get(api);
+            var json = await Http.GetAsync(api);
 
             var releases = JsonConvert.DeserializeObject<List<GithubRelease>>(json);
             var latest = releases.Where(r => !r.Prerelease).OrderByDescending(r => r.PublishedAt).First();

Flow.Launcher.Infrastructure/Http/Http.cs

@@ -89,13 +89,23 @@ public static async Task Download([NotNull] string url, [NotNull] string filePat
             }
         }
 
-        public static async Task<string> Get([NotNull] string url, string encoding = "UTF-8")
+        /// <summary>
+        /// Asynchrously get the result as string from url.
+        /// When supposing the result is long and large, try using GetStreamAsync to avoid reading as string
+        /// </summary>
+        /// <param name="url"></param>
+        /// <returns></returns>
+        public static Task<string> GetAsync([NotNull] string url)
         {
             Log.Debug($"|Http.Get|Url <{url}>");
-            var response = await client.GetAsync(url);
-            await using var stream = await response.Content.ReadAsStreamAsync();
-            using var reader = new StreamReader(stream, Encoding.GetEncoding(encoding));
-            var content = await reader.ReadToEndAsync();
+            return GetAsync(new Uri(url.Replace("#", "%23")));
+        }
+
+        public static async Task<string> GetAsync([NotNull] Uri url)
+        {
+            Log.Debug($"|Http.Get|Url <{url}>");
+            using var response = await client.GetAsync(url);
+            var content = await response.Content.ReadAsStringAsync();
             if (response.StatusCode == HttpStatusCode.OK)
             {
                 return content;
@@ -107,6 +117,11 @@ public static async Task<string> Get([NotNull] string url, string encoding = "UT
             }
         }
 
+        /// <summary>
+        /// Asynchrously get the result as stream from url.
+        /// </summary>
+        /// <param name="url"></param>
+        /// <returns></returns>
         public static async Task<Stream> GetStreamAsync([NotNull] string url)
         {
             Log.Debug($"|Http.Get|Url <{url}>");

Plugins/Flow.Launcher.Plugin.WebSearch/SuggestionSources/Baidu.cs

@@ -8,6 +8,7 @@
 using Newtonsoft.Json.Linq;
 using Flow.Launcher.Infrastructure.Http;
 using Flow.Launcher.Infrastructure.Logger;
+using System.Net.Http;
 
 namespace Flow.Launcher.Plugin.WebSearch.SuggestionSources
 {
@@ -22,9 +23,9 @@ public override async Task<List<string>> Suggestions(string query)
             try
             {
                 const string api = "http://suggestion.baidu.com/su?json=1&wd=";
-                result = await Http.Get(api + Uri.EscapeUriString(query), "GB2312");
+                result = await Http.GetAsync(api + Uri.EscapeUriString(query)).ConfigureAwait(false);
             }
-            catch (WebException e)
+            catch (HttpRequestException e)
             {
                 Log.Exception("|Baidu.Suggestions|Can't get suggestion from baidu", e);
                 return new List<string>();

Plugins/Flow.Launcher.Plugin.WebSearch/SuggestionSources/Google.cs

@@ -7,6 +7,7 @@
 using Newtonsoft.Json.Linq;
 using Flow.Launcher.Infrastructure.Http;
 using Flow.Launcher.Infrastructure.Logger;
+using System.Net.Http;
 
 namespace Flow.Launcher.Plugin.WebSearch.SuggestionSources
 {
@@ -18,13 +19,12 @@ public override async Task<List<string>> Suggestions(string query)
             try
             {
                 const string api = "https://www.google.com/complete/search?output=chrome&q=";
-                result = await Http.Get(api + Uri.EscapeUriString(query));
+                result = await Http.GetAsync(api + Uri.EscapeUriString(query)).ConfigureAwait(false);
             }
-            catch (WebException e)
+            catch (HttpRequestException e)
             {
                 Log.Exception("|Google.Suggestions|Can't get suggestion from google", e);
                 return new List<string>();
-                ;
             }
             if (string.IsNullOrEmpty(result)) return new List<string>();
             JContainer json;