Skip to content

Commit 197e9c4

Browse files
committed
Improve code comments
1 parent 5665758 commit 197e9c4

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

Flow.Launcher/App.xaml.cs

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,12 +79,16 @@ public App()
7979
.AddSingleton<StringMatcher>()
8080
.AddSingleton<Internationalization>()
8181
.AddSingleton<IPublicAPI, PublicAPIInstance>()
82-
.AddSingleton<MainViewModel>()
8382
.AddSingleton<Theme>()
84-
// Welcome view model & setting window view model is very simple so we just use one instance
85-
.AddSingleton<SettingWindowViewModel>()
83+
// Use one instance for main window view model because we only have one main window
84+
.AddSingleton<MainViewModel>()
85+
// Use one instance for welcome window view model & setting window view model because
86+
// pages in welcome window & setting window need to share the same instance and
87+
// these two view models do not need to be reset when creating new windows
8688
.AddSingleton<WelcomeViewModel>()
87-
// Setting page view models are complex so we use transient instance
89+
.AddSingleton<SettingWindowViewModel>()
90+
// Use transient instance for setting window page view models because
91+
// pages in setting window need to be recreated when setting window is closed
8892
.AddTransient<SettingsPaneAboutViewModel>()
8993
.AddTransient<SettingsPaneGeneralViewModel>()
9094
.AddTransient<SettingsPaneHotkeyViewModel>()

0 commit comments

Comments
 (0)