only modify property when async (avoid duplicate read)

taooceros · taooceros · commit 1c6d207595c9 · 2021-05-24T10:34:16.000+08:00
diff --git a/Flow.Launcher/ViewModel/ResultViewModel.cs b/Flow.Launcher/ViewModel/ResultViewModel.cs
@@ -59,7 +59,7 @@ private async void LoadImage()
             {
                 try
                 {
-                    Image = Result.Icon();
+                    image = Result.Icon();
                     return;
                 }
                 catch (Exception e)
@@ -71,7 +71,7 @@ private async void LoadImage()
             if (ImageLoader.CacheContainImage(imagePath))
             {
                 // will get here either when icoPath has value\icon delegate is null\when had exception in delegate
-                Image = ImageLoader.Load(imagePath);
+                image = ImageLoader.Load(imagePath);
                 return;
             }
             

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ private async void LoadImage()`
`59`	`59`	`{`
`60`	`60`	`try`
`61`	`61`	`{`
`62`		`- Image = Result.Icon();`
	`62`	`+ image = Result.Icon();`
`63`	`63`	`return;`
`64`	`64`	`}`
`65`	`65`	`catch (Exception e)`
`@@ -71,7 +71,7 @@ private async void LoadImage()`
`71`	`71`	`if (ImageLoader.CacheContainImage(imagePath))`
`72`	`72`	`{`
`73`	`73`	`// will get here either when icoPath has value\icon delegate is null\when had exception in delegate`
`74`		`- Image = ImageLoader.Load(imagePath);`
	`74`	`+ image = ImageLoader.Load(imagePath);`
`75`	`75`	`return;`
`76`	`76`	`}`
`77`	`77`