Make Plugin dictionary private

Author: Jack251970

Flow.Launcher.Core/Plugin/PluginManager.cs

@@ -622,7 +622,7 @@ internal static async Task UninstallPluginAsync(PluginMetadata plugin, bool remo
                     API.ShowMsg(API.GetTranslation("failedToRemovePluginCacheTitle"),
                         string.Format(API.GetTranslation("failedToRemovePluginCacheMessage"), plugin.Name));
                 }
-                Settings.Plugins.Remove(plugin.ID);
+                Settings.RemovePluginSettings(plugin.ID);
                 AllPlugins.RemoveAll(p => p.Metadata.ID == plugin.ID);
             }
 

Flow.Launcher.Infrastructure/UserSettings/PluginSettings.cs

@@ -27,7 +27,7 @@ public string NodeExecutablePath
             }
         }
 
-        public Dictionary<string, Plugin> Plugins { get; set; } = new Dictionary<string, Plugin>();
+        private Dictionary<string, Plugin> Plugins { get; set; } = new();
 
         public void UpdatePluginSettings(List<PluginMetadata> metadatas)
         {
@@ -67,6 +67,21 @@ public void UpdatePluginSettings(List<PluginMetadata> metadatas)
                 }
             }
         }
+
+        public Plugin GetPluginSettings(string id)
+        {
+            if (Plugins.TryGetValue(id, out var plugin))
+            {
+                return plugin;
+    }
+            return null;
+        }
+
+        public Plugin RemovePluginSettings(string id)
+        {
+            Plugins.Remove(id, out var plugin);
+            return plugin;
+        }
     }
 
     public class Plugin

Flow.Launcher/SettingPages/ViewModels/SettingsPanePluginsViewModel.cs

@@ -30,8 +30,9 @@ public SettingsPanePluginsViewModel(Settings settings)
         .Select(plugin => new PluginViewModel
         {
             PluginPair = plugin,
-            PluginSettingsObject = _settings.PluginSettings.Plugins[plugin.Metadata.ID]
+            PluginSettingsObject = _settings.PluginSettings.GetPluginSettings(plugin.Metadata.ID)
         })
+        .Where(plugin => plugin.PluginSettingsObject != null)
         .ToList();
 
     public List<PluginViewModel> FilteredPluginViewModels => PluginViewModels